From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AB6431E76 for ; Thu, 23 Jul 2026 10:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784801013; cv=none; b=ICj5s0mcDbvWvPqn6hGKjGjyS5awefcsT63i/u3Pd4rxhzjIrroqMBErHeeLU5twQUjAP72ibJJwQwcw7aqQdZOr1c890TevLU43eVAvW5KxozAd9z2O1vxSvS47r+pgfme7psIY4IK9tk0cbFKVmrc/Om8/hRDNb8NogJFp8qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784801013; c=relaxed/simple; bh=xyALdxjU1TW9/Ki7zm9C1YzWa0+d5DiMlT8No6I9Mes=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ob8Mx8EbBuc1l/5VmAhoHaMLUftuM09cPr1YyhGlJDYfrUQiC1QW7qdmkDzZka40slzqpmky5iDOi+cifctjxp2sG8knYx2psoSlIAARrt7Qyg0SnfWmIlFykpNJxeBeonfdOHTjuv1PdUIJdKD31G49q5L06XzWZMY80+6/QIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Mc/Tz0aL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mc/Tz0aL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784801007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BOWCDRxNUNYjz7orMFcedmQGQ2BN2L8e1lJ1KDGIQsg=; b=Mc/Tz0aLez3mSOcvMeio0BvZCfZJa9Y0ILmHubDM5OExviCkmhwEMfcmMogeLuZJLhNC26 uPe8Wyrtc3QsRjiVf54t5Ey1ROHyHovKYuKt0PLL8Zu1Al9bdNhTKWZD7COAd4m3dsJu/A Slw4xzUjTXuRKtoxrwA48p8+GHFTStA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-KbjD4K-5P7qMvSeAR-7mug-1; Thu, 23 Jul 2026 06:03:21 -0400 X-MC-Unique: KbjD4K-5P7qMvSeAR-7mug-1 X-Mimecast-MFC-AGG-ID: KbjD4K-5P7qMvSeAR-7mug_1784801000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15880180074E; Thu, 23 Jul 2026 10:03:20 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.33.159]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CB900196B0A6; Thu, 23 Jul 2026 10:03:16 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Jeffrey Altman Subject: [PATCH net v4 1/9] rxrpc: Fix sendmsg to not return an error if last packet queued Date: Thu, 23 Jul 2026 11:02:57 +0100 Message-ID: <20260723100309.530157-2-dhowells@redhat.com> In-Reply-To: <20260723100309.530157-1-dhowells@redhat.com> References: <20260723100309.530157-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Fix AF_RXRPC sendmsg() so that it doesn't return an error if it has successfully queued the last packet of a call, but the call has seen to have completed after it did that. Rather, leave it to recvmsg() to report the completion (which it will do anyway). The problem with trying to report the error twice is that the caller may try to clean up the dead call twice. Fixes: d41b3f5b9688 ("rxrpc: Wrap accesses to get call state to put the barrier in one place") Signed-off-by: David Howells cc: Marc Dionne cc: Jeffrey Altman cc: Eric Dumazet cc: "David S. Miller" cc: Jakub Kicinski cc: Paolo Abeni cc: Simon Horman cc: linux-afs@lists.infradead.org --- net/rxrpc/sendmsg.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index ed2c9a51005a..4c754f78ece9 100644 --- a/net/rxrpc/sendmsg.c +++ b/net/rxrpc/sendmsg.c @@ -453,9 +453,6 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, success: ret = copied; - if (rxrpc_call_is_complete(call) && - call->error < 0) - ret = call->error; out: call->tx_pending = txb; _leave(" = %d", ret); @@ -467,8 +464,14 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, return call->error; maybe_error: - if (copied) + if (copied) { + if (rxrpc_call_is_complete(call) && + call->error < 0) { + ret = call->error; + goto out; + } goto success; + } goto out; efault: