Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: luoqing <l1138897701@163.com>
Cc: lucien.xin@gmail.com, davem@davemloft.net, edumazet@google.com,
	horms@kernel.org, linux-kernel@vger.kernel.org,
	linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
	netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v5] sctp: auth: discard auth_chunk when skb_clone fails
Date: Thu, 23 Jul 2026 10:16:32 -0700	[thread overview]
Message-ID: <20260723101632.77849674@kernel.org> (raw)
In-Reply-To: <20260723061107.384106-1-l1138897701@163.com>

On Thu, 23 Jul 2026 14:11:07 +0800 luoqing wrote:
> When processing AUTH + COOKIE-ECHO packets, if skb_clone() fails
> due to memory pressure, chunk->auth_chunk is NULL. The original
> code still sets chunk->auth = 1 and continues, leaving the
> COOKIE-ECHO to be processed without a valid auth_chunk for
> deferred verification.
> 
> Discard the AUTH chunk early via pdiscard when skb_clone() fails,
> so that the receive loop can continue processing remaining chunks
> in the inqueue instead of stalling the entire packet.

Please stop sending patches in reply to existing threads.

  reply	other threads:[~2026-07-23 17:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  1:55 [PATCH v4 net-next] sctp: auth: break when skb_clone fails for auth_chunk luoqing
2026-07-21  1:55 ` [PATCH v4 net] sctp: auth: verify auth requirement when auth_chunk is NULL luoqing
2026-07-22 17:37   ` Xin Long
2026-07-22 21:00   ` patchwork-bot+netdevbpf
2026-07-22 18:31 ` [PATCH v4 net-next] sctp: auth: break when skb_clone fails for auth_chunk Xin Long
2026-07-23  6:11   ` [PATCH net-next v5] sctp: auth: discard auth_chunk when skb_clone fails luoqing
2026-07-23 17:16     ` Jakub Kicinski [this message]
2026-07-29  1:23     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723101632.77849674@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=l1138897701@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox