Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: ZhaoJinming <zhaojinming@uniontech.com>
Cc: horms@kernel.org, madalin.bucur@nxp.com, sean.anderson@linux.dev,
	netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 0/2] net: fman: fix IRQ-related bugs and add probe cleanup
Date: Thu, 23 Jul 2026 10:26:36 -0700	[thread overview]
Message-ID: <20260723102636.28b4d920@kernel.org> (raw)
In-Reply-To: <20260721085841.488088-1-zhaojinming@uniontech.com>

On Tue, 21 Jul 2026 16:58:39 +0800 ZhaoJinming wrote:
> This v2 series addresses the feedback from the previous irq_ready flag
> approach (v1) and the separate UAF fix patch (v3). It replaces both
> with a single root-cause fix: moving IRQ registration after driver
> initialization is complete.

The cover letter must explain how the issues were discovered and how
they were tested (what HW platform you tested on etc). Also:

Warning: drivers/net/ethernet/freescale/fman/fman_muram.c:133 missing initial short description on line:
 * fman_muram_finish
Warning: drivers/net/ethernet/freescale/fman/fman_muram.c:133 missing initial short description on line:
 * fman_muram_finish
-- 
pw-bot: cr

      parent reply	other threads:[~2026-07-23 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03  7:43 [PATCH net v2 1/2] net: fman: move IRQ registration after init to prevent NULL deref and UAF ZhaoJinming
2026-07-03  7:43 ` [PATCH net v2 2/2] net: fman: add error cleanup path in fman_probe ZhaoJinming
2026-07-09 14:56   ` Simon Horman
2026-07-09 14:52 ` [PATCH net v2 1/2] net: fman: move IRQ registration after init to prevent NULL deref and UAF Simon Horman
2026-07-21  8:58   ` [PATCH net v2 0/2] net: fman: fix IRQ-related bugs and add probe cleanup ZhaoJinming
2026-07-21  8:58     ` [PATCH net v2 1/2] net: fman: move IRQ registration after init to prevent NULL deref and UAF ZhaoJinming
2026-07-21  8:58     ` [PATCH net v2 2/2] net: fman: add error cleanup path in fman_probe ZhaoJinming
2026-07-23 17:26     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723102636.28b4d920@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sean.anderson@linux.dev \
    --cc=zhaojinming@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox