From: mheib@redhat.com
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
corbet@lwn.net, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
horms@kernel.org, Mohammad Heib <mheib@redhat.com>
Subject: [PATCH iwl-next v4 0/3] i40e: add runtime-tunable ATR sample rate
Date: Thu, 23 Jul 2026 17:04:14 +0300 [thread overview]
Message-ID: <20260723140510.184819-1-mheib@redhat.com> (raw)
From: Mohammad Heib <mheib@redhat.com>
This series makes the Flow Director ATR sample rate configurable at
runtime through a devlink parameter.
On systems with many queues and high-rate TCP workloads, the fixed
default sampling interval can cause frequent Flow Director
reprogramming and TCP packet reordering. The optimal interval depends
on the workload and system configuration.
Patch 1 moves atr_sample_rate from per-ring to PF level, since it is
a global policy.
Patch 2 exposes it as a devlink runtime parameter so administrators
can tune it without rebuilding the driver.
Patch 3 fixes a pre-existing issue where re-enabling ATR via ethtool
private flags did not trigger a ring reset, leaving fd_ena stale in
the TX queue HW context.
Changes since v3:
- Added READ_ONCE() in i40e_atr() for lockless access to
pf->atr_sample_rate (patch 1).
- Added WRITE_ONCE()/READ_ONCE() in devlink setter/getter (patch 2)
- New patch: trigger PF reset when re-enabling ATR (patch 3)
---
Mohammad Heib (3):
i40e: move ATR sample rate from ring to PF level
i40e: add devlink parameter for Flow Director ATR sample rate
i40e: trigger PF reset when re-enabling ATR via ethtool
Documentation/networking/devlink/i40e.rst | 20 +++++++++++
drivers/net/ethernet/intel/i40e/i40e.h | 1 +
.../net/ethernet/intel/i40e/i40e_devlink.c | 36 +++++++++++++++++++
.../net/ethernet/intel/i40e/i40e_ethtool.c | 7 ++++
drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 ++--
drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 +-
7 files changed, 72 insertions(+), 10 deletions(-)
--
2.53.0
next reply other threads:[~2026-07-23 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 14:04 mheib [this message]
2026-07-23 14:04 ` [PATCH iwl-next v4 1/3] i40e: move ATR sample rate from ring to PF level mheib
2026-07-23 14:04 ` [PATCH iwl-next v4 2/3] i40e: add devlink parameter for Flow Director ATR sample rate mheib
2026-07-23 14:04 ` [PATCH iwl-next v4 3/3] i40e: trigger PF reset when re-enabling ATR via ethtool mheib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723140510.184819-1-mheib@redhat.com \
--to=mheib@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox