Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	David Ahern <dsahern@kernel.org>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] net: do not send ICMP/NDISC Redirects when peer allocation fails
Date: Fri, 24 Jul 2026 07:20:37 -0700	[thread overview]
Message-ID: <20260724072037.26b2a672@kernel.org> (raw)
In-Reply-To: <CANn89iKuh3PbaoWskJEd7MXWZNmLDUNH7DdtE7hmAz+MTOybnw@mail.gmail.com>

On Fri, 24 Jul 2026 16:15:54 +0200 Eric Dumazet wrote:
> I have no idea really :/
> 
> vng --cwd tools/testing/selftests/net -p 4 -r ./arch/x86/boot/bzImage
> -- ./fib_tests.sh
> 
>  All tests are [ OK ] for me.
> 
> Tests passed: 257
> Tests failed:   0
> 
> Note that my change in ip6_forward() does not early-return, unless I
> am mistaken.

Ack, weird. The only two other patches that came in recently seem to be:

  net: ip6_tunnel: use tunnel parameters for fill_forward_path route lookup
  net: udp_tunnel: fix memory leak in udp_tunnel_nic_unregister()

neither of which seem like they should cause this :/

I'll keep this patch in and keep an eye..

      reply	other threads:[~2026-07-24 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  7:29 [PATCH net] net: do not send ICMP/NDISC Redirects when peer allocation fails Eric Dumazet
2026-07-24 13:42 ` Jakub Kicinski
2026-07-24 14:15   ` Eric Dumazet
2026-07-24 14:20     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724072037.26b2a672@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox