Re: [PATCH net-next 5/6] selftest: add tc-testing JSON test cases for act_frer

[Simon Horman <horms@kernel.org>]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
Full review at: https://sashiko.dev/#/patchset/20260717095549.10565-3-xiaoliang.yang_1@nxp.com?part=5
---
--- Patch [5]: [PATCH net-next 5/6] selftest: add tc-testing JSON test cases for act_frer ---
commit a49cd24c7418264cc3093ec982fc3e60a41c9d2b
Author: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>

selftest: add tc-testing JSON test cases for act_frer

This commit adds a tc-testing JSON file covering the FRER (IEEE 802.1CB
Frame Replication and Elimination for Reliability) tc action. It introduces
32 test cases that exercise various parameters, statistics, and filter
bindings.

> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/frer.json b/tools/testing/selftests/tc-testing/tc-tests/actions/frer.json
> new file mode 100644
> index 0000000000000..d5be6ae156f79
> --- /dev/null
> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/frer.json
> @@ -0,0 +1,785 @@
> +[
[ ... ]
> +  {
> +    "id": "frer_0027",
> +    "name": "Bind frer push action to egress clsact filter",
> +    "category": [
> +      "actions",
> +      "frer"
> +    ],
> +    "setup": [
> +      [
> +        "modprobe act_frer",
> +        0,
> +        1
> +      ],
> +      "ip link del frer_dummy 2>/dev/null || true",
> +      "ip link add frer_dummy type dummy",
> +      "ip link set frer_dummy up",

[Severity: Medium]
Will these tests run in the host's default network namespace because they omit
the nsPlugin requirement?

If a test aborts or crashes before the teardown stage, this could leak dummy
interfaces into the host's root namespace.

[ ... ]
> +  {
> +    "id": "frer_0029",
> +    "name": "Share frer recover action across two ingress filters (refcount check)",
> +    "category": [
> +      "actions",
> +      "frer"
> +    ],
> +    "setup": [
> +      [
> +        "modprobe act_frer",
> +        0,
> +        1
> +      ],
> +      "ip link del frer_a 2>/dev/null || true",
> +      "ip link del frer_b 2>/dev/null || true",
> +      "ip link add frer_a type dummy",
> +      "ip link add frer_b type dummy",

[Severity: Medium]
Similarly, will these dummy interfaces also leak into the host network
namespace if the test fails before teardown?

Could these tests be updated to require nsPlugin to ensure they run in an
isolated network namespace?