From: Greg KH <gregkh@linuxfoundation.org>
To: Hongyan Xu <getshell@seu.edu.cn>
Cc: sashal@kernel.org, 3chas3@gmail.com, stable@vger.kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn
Subject: Re: [RFC PATCH 6.6.y] atm: he: kill tasklet before releasing queues
Date: Fri, 24 Jul 2026 07:45:12 +0200 [thread overview]
Message-ID: <2026072445-delicious-uncrushed-b854@gregkh> (raw)
In-Reply-To: <20260724052710.1126-1-getshell@seu.edu.cn>
On Fri, Jul 24, 2026 at 01:27:10PM +0800, Hongyan Xu wrote:
> The interrupt handler schedules a tasklet which accesses the device queues.
> tasklet_disable() waits for a running instance, but leaves a scheduled
> instance pending while he_stop() releases those queues and the device.
>
> After masking device interrupts, unregister the IRQ so the handler can no
> longer schedule the tasklet, then kill the tasklet before releasing any of
> its data.
>
> The affected driver was removed upstream by commit 6deb53595092 ("net:
> remove unused ATM protocols and legacy ATM device drivers"). This change
> is intended for maintained stable kernels which still carry the driver.
Why don't we just delete the driver instead as obviously no one uses
this. Unless you have the hardware to test these changes?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-24 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 5:27 [RFC PATCH 6.6.y] atm: he: kill tasklet before releasing queues Hongyan Xu
2026-07-24 5:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026072445-delicious-uncrushed-b854@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=3chas3@gmail.com \
--cc=getshell@seu.edu.cn \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox