From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
To: "Linus Walleij" <linusw@kernel.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Michael Rasmussen" <mir@bang-olufsen.dk>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Mieczyslaw Nalewaj" <namiltd@yahoo.com>
Cc: Luiz Angelo Daros de Luca <luizluca@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v2 4/4] net: dsa: realtek: use devm_mutex_init for l2_lock
Date: Sun, 26 Jul 2026 22:56:11 -0300 [thread overview]
Message-ID: <20260726-realtek_mutext-v2-4-5d62ba998791@gmail.com> (raw)
In-Reply-To: <20260726-realtek_mutext-v2-0-5d62ba998791@gmail.com>
With CONFIG_DEBUG_MUTEXES enabled, mutex_destroy() needs to be called
before the lock is discarded. Use devm_mutex_init() instead so the
cleanup is handled automatically.
Fixes: 336e3e4a1ab37 ("net: dsa: realtek: rtl8365mb: add FDB support")
Reviewed-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
drivers/net/dsa/realtek/rtl83xx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/realtek/rtl83xx.c b/drivers/net/dsa/realtek/rtl83xx.c
index 9f40afb19ab2..9dd50b20c000 100644
--- a/drivers/net/dsa/realtek/rtl83xx.c
+++ b/drivers/net/dsa/realtek/rtl83xx.c
@@ -164,7 +164,9 @@ rtl83xx_probe(struct device *dev,
if (ret)
return ERR_PTR(ret);
- mutex_init(&priv->l2_lock);
+ ret = devm_mutex_init(dev, &priv->l2_lock);
+ if (ret)
+ return ERR_PTR(ret);
rc.lock_arg = priv;
priv->map = devm_regmap_init(dev, NULL, priv, &rc);
--
2.55.0
prev parent reply other threads:[~2026-07-27 1:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 1:56 [PATCH net v2 0/4] net: dsa: realtek: use devm_mutex_init Luiz Angelo Daros de Luca
2026-07-27 1:56 ` [PATCH net v2 1/4] net: dsa: realtek: rtl8365mb: use devm_mutex_init for mib_lock Luiz Angelo Daros de Luca
2026-07-27 1:56 ` [PATCH net v2 2/4] net: dsa: realtek: use devm_mutex_init for regmap lock Luiz Angelo Daros de Luca
2026-07-27 1:56 ` [PATCH net v2 3/4] net: dsa: realtek: use devm_mutex_init for vlan_lock Luiz Angelo Daros de Luca
2026-07-27 1:56 ` Luiz Angelo Daros de Luca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726-realtek_mutext-v2-4-5d62ba998791@gmail.com \
--to=luizluca@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mir@bang-olufsen.dk \
--cc=namiltd@yahoo.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox