From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Sagi Maimon <maimon.sagi@gmail.com>,
jonathan.lemon@gmail.com, richardcochran@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v6] ptp: ocp: add CPLD ISP support for ADVA TimeCard X1
Date: Mon, 27 Jul 2026 14:03:20 -0700 [thread overview]
Message-ID: <20260727140320.54185eb8@kernel.org> (raw)
In-Reply-To: <118da808-b9e0-4e5a-9094-9c6dc3740ff4@linux.dev>
On Mon, 27 Jul 2026 12:02:53 +0100 Vadim Fedorenko wrote:
> I don't like the idea of having a buffer in a global structure. And it
> doesn't look like you can actually serialize access. Imaging 2 processes
> manipulating this i2c bus. I can be that mutex will put them like:
>
> 1. process1 -> write cmd
> 2. process2 -> write cmd
> 3. process1 -> read result
>
> That means the data will be a mess.
>
> That's why it is a really bad thing to allow direct access from the user
> space. Is it possible to add a property per command?
At a glance - adding I2C support via 2 magic files in sysfs is rather
odd. Either expose a real i2c bus or make the driver sends the
appropriate commands. We are opposed to raw device write interfaces in
netdev.
prev parent reply other threads:[~2026-07-27 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 14:39 [PATCH v6] ptp: ocp: add CPLD ISP support for ADVA TimeCard X1 Sagi Maimon
2026-07-27 11:02 ` Vadim Fedorenko
2026-07-27 21:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727140320.54185eb8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maimon.sagi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox