From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Liu <1298662399@qq.com>
Cc: Jian Shen <shenjian15@huawei.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hisilicon: hix5hd2_gmac: fix NAPI teardown order
Date: Mon, 27 Jul 2026 15:58:48 -0700 [thread overview]
Message-ID: <20260727155848.387245f6@kernel.org> (raw)
In-Reply-To: <tencent_3C891D50F517A212AE7EAA88051244B7C005@qq.com>
On Sun, 26 Jul 2026 10:35:55 +0400 Jiawen Liu wrote:
> hix5hd2_dev_remove() deletes the NAPI instance before unregistering the
> netdev.
>
> The netdev should be unregistered first so the networking core can stop the
> device while its NAPI instance is still present. Delete the NAPI instance
> after unregister_netdev() has completed, matching the usual teardown order
> for drivers that call netif_napi_add() during probe.
Just delete that call. Unregistering deletes all the NAPIs
automatically. Also you're missing a Fixes tag
--
pw-bot: cr
prev parent reply other threads:[~2026-07-27 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 6:35 [PATCH] net: hisilicon: hix5hd2_gmac: fix NAPI teardown order Jiawen Liu
2026-07-27 22:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727155848.387245f6@kernel.org \
--to=kuba@kernel.org \
--cc=1298662399@qq.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox