From: Simon Horman <horms@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Mengyuan Lou <mengyuanlou@net-swift.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Kees Cook <kees@kernel.org>
Subject: Re: [PATCH net] net: libwx: fix FDIR ATR queue mismatch for software VLAN packets
Date: Tue, 28 Jul 2026 17:54:19 +0100 [thread overview]
Message-ID: <20260728165419.GV418547@horms.kernel.org> (raw)
In-Reply-To: <0879DA38A8E32701+20260724074657.10773-1-jiawenwu@trustnetic.com>
On Fri, Jul 24, 2026 at 03:46:57PM +0800, Jiawen Wu wrote:
> When TX VLAN hardware offload is disabled, VLAN tags are embedded in
> the packet payload (software VLAN). Previously, the driver failed to
> set the WX_TX_FLAGS_SW_VLAN flag for these packets during transmission.
>
> This missing flag caused the txgbe FDIR ATR logic to fall through to the
> default hash calculation path. This resulted in asymmetric hash values
> for Tx and Rx flows, preventing return packets from being steered to the
> same queue as the transmit packets.
>
> Fix this by detecting software VLANs via eth_type_vlan(skb->protocol)
> and setting WX_TX_FLAGS_SW_VLAN. This ensures the ATR feature selects
> the correct hashing algorithm to maintain Tx/Rx queue symmetry.
>
> Fixes: b501d261a5b3 ("net: txgbe: add FDIR ATR support")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-07-28 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:46 [PATCH net] net: libwx: fix FDIR ATR queue mismatch for software VLAN packets Jiawen Wu
2026-07-28 16:54 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728165419.GV418547@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox