From: Jiaxing Hu <gahing@gahingwoo.com>
To: andrew@lunn.ch
Cc: alchark@gmail.com, attinagaoxu@gmail.com,
Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
maxime.chevallier@bootlin.com, heiko@sntech.de,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH net-next v2] net: phy: motorcomm: enable the reference clock for YT8521 and YT8531
Date: Wed, 29 Jul 2026 11:09:16 +1200 [thread overview]
Message-ID: <20260728230916.1239080-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <37c2162d-134d-48c5-92d8-3355306f15ec@lunn.ch>
> Look around at other drivers. Is it generally put into a tiny helper,
> or used inline?
>
> My gut feeling from reviewing lots of drivers is that it is inline.
Agreed. v3 open-codes the get-and-enable in both yt8521_probe and
yt8531_probe, with no helper. I had already sent it before this mail:
https://lore.kernel.org/all/20260728055659.1211459-1-gahing@gahingwoo.com/
It carries your Reviewed-by and Gavin's Tested-by.
Jiaxing
prev parent reply other threads:[~2026-07-28 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 20:56 [PATCH net-next v2] net: phy: motorcomm: enable the reference clock for YT8521 and YT8531 Jiaxing Hu
2026-07-28 2:14 ` Gavin Gao
2026-07-28 4:16 ` Alexey Charkov
2026-07-28 13:57 ` Gavin Gao
2026-07-28 20:54 ` Andrew Lunn
2026-07-28 23:09 ` Jiaxing Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728230916.1239080-1-gahing@gahingwoo.com \
--to=gahing@gahingwoo.com \
--cc=Frank.Sae@motor-comm.com \
--cc=alchark@gmail.com \
--cc=andrew@lunn.ch \
--cc=attinagaoxu@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox