Netdev List
 help / color / mirror / Atom feed
From: Minxi Hou <houminxi@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, aconole@redhat.com, echaudro@redhat.com,
	i.maximets@ovn.org, dev@openvswitch.org,
	linux-kselftest@vger.kernel.org, shuah@kernel.org,
	horms@kernel.org, linux-kernel@vger.kernel.org,
	Minxi Hou <houminxi@gmail.com>
Subject: [PATCH net-next v7 0/2] selftests: openvswitch: SCTP flow key parsing
Date: Wed, 29 Jul 2026 02:45:47 -0400	[thread overview]
Message-ID: <20260729064549.3647518-1-houminxi@gmail.com> (raw)

Add OVS_KEY_ATTR_SCTP to the ovskey parse table in ovs-dpctl.py so
that SCTP flow strings carry the L4 key through to the kernel, and
add a matching selftest in openvswitch.sh.

The missing parse-table entry caused a selftest NIPA failure: the
flow string "sctp(dst=4443)" parsed without error but silently
dropped the L4 key, producing a flow with only ipv4(proto=132).
The kernel's match_validate() then rejected it with -EINVAL because
OVS_KEY_ATTR_SCTP was missing for IPPROTO_SCTP.

Changes from v6:
  - Trim unit tests to cover only the new SCTP key parser
    (removed tests for TCP/UDP/ICMP/IPv4/EthType which were out of
    scope for this patch); address Aaron's feedback that testing
    existing parsers was excessive for a selftest tool.
  - _parse_flow() now checks for unparsed remainder.

v6: https://lore.kernel.org/netdev/20260724150624.3457427-1-houminxi@gmail.com/
v5: https://lore.kernel.org/netdev/20260723215630.2502169-1-houminxi@gmail.com/
v4: https://lore.kernel.org/netdev/20260723162503.1790998-1-houminxi@gmail.com/
v3: https://lore.kernel.org/netdev/20260722214915.4128292-1-houminxi@gmail.com/
v2: https://lore.kernel.org/netdev/20260721190648.2713156-1-houminxi@gmail.com/
v1: https://lore.kernel.org/netdev/20260718215437.3257200-1-houminxi@gmail.com/

Minxi Hou (2):
  selftests/net/openvswitch: add SCTP flow key parsing to ovs-dpctl.py
  selftests/net/openvswitch: add SCTP flow key test

 .../testing/selftests/net/openvswitch/openvswitch.sh   | 121 +++++++++++++++++
 .../testing/selftests/net/openvswitch/ovs-dpctl.py     |  82 ++++++++++++
 2 files changed, 203 insertions(+)

--
2.55.0


             reply	other threads:[~2026-07-29  6:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  6:45 Minxi Hou [this message]
2026-07-29  6:45 ` [PATCH 1/2] selftests/net/openvswitch: add SCTP flow key parsing to ovs-dpctl.py Minxi Hou
2026-07-29  6:45 ` [PATCH 2/2] selftests/net/openvswitch: add SCTP flow key test Minxi Hou
2026-07-29 16:01 ` [PATCH net-next v7 0/2] selftests: openvswitch: SCTP flow key parsing Ilya Maximets

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729064549.3647518-1-houminxi@gmail.com \
    --to=houminxi@gmail.com \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox