From: Andrew Morton <akpm@linux-foundation.org>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Jing Wu <realwujing@gmail.com>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Lance Yang <lance.yang@linux.dev>, SeongJae Park <sj@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v11] mm/page_alloc: boost watermarks on atomic allocation failure
Date: Wed, 29 Jul 2026 15:06:20 -0700 [thread overview]
Message-ID: <20260729150620.7631d856d938d657e60547d1@linux-foundation.org> (raw)
In-Reply-To: <6ddc5919-f001-43ad-8101-d118ad70593f@kernel.org>
On Wed, 29 Jul 2026 16:00:29 +0200 "Vlastimil Babka (SUSE)" <vbabka@kernel.org> wrote:
> Great, especially with a realistic workload. However I'd still worry that
> we're working around some old and long time fixed allocator deficiency from
> 4.19, unless it's demonstrated on mainline.
Yes, 4,19 is soooo old.
I asked Jakub Kicinski about this patch. Off-list, reproduced without
permission:
: Most networking drivers today use the page pool API, which should
: provide a cache of pages circulating between the TCP stack and the
: driver. If the system is in dire straights we recommend the drivers
: allow the queues to run dry and get refilled from a watchdog once
: system recovers.
:
: IDK how good the code looks from MM side, but from networking side
: there is a lot of unanswered questions.
So it's quite possible that this change simply is no longer relevant
for drivers which anyone seriously cares about.
Clearly the next step here is to test a modern kernel and a modern
driver then decide if there's still a problem to be fixed. Please.
prev parent reply other threads:[~2026-07-29 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 8:15 [PATCH v11] mm/page_alloc: boost watermarks on atomic allocation failure Qiliang Yuan
2026-07-20 23:37 ` Andrew Morton
2026-07-21 15:10 ` Vlastimil Babka (SUSE)
2026-07-29 13:17 ` Jing Wu
2026-07-29 14:00 ` Vlastimil Babka (SUSE)
2026-07-29 14:27 ` Jing Wu
2026-07-29 22:06 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729150620.7631d856d938d657e60547d1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=axelrasmussen@google.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=lance.yang@linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=realwujing@gmail.com \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox