From: Jakub Kicinski <kuba@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Florian Westphal <fw@strlen.de>,
Davide Caratti <dcaratti@redhat.com>,
Christoph Paasch <cpaasch@openai.com>
Subject: Re: [PATCH net 1/5] mptcp: avoid combining some incoming suboptions
Date: Wed, 29 Jul 2026 17:23:06 -0700 [thread overview]
Message-ID: <20260729172306.31deb67d@kernel.org> (raw)
In-Reply-To: <20260728-net-mptcp-misc-fixes-7-2-rc6-v1-1-f7e2d229159d@kernel.org>
On Tue, 28 Jul 2026 19:11:57 +0200 Matthieu Baerts (NGI0) wrote:
> Some MPTCP suboptions are mutually exclusive according to the RFC8684,
> but also because in different places, the code doesn't expect some
> combinations to be present. That's specially true for suboptions that
> would be present twice, but with different attributes.
Looks like Clashiko has much to say about this patch.
Could you check?
From my perspective I'm not sure if such RFC compliance changes
really belong as Fixes? I don't feel too strongly tho.
next prev parent reply other threads:[~2026-07-30 0:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 17:11 [PATCH net 0/5] mptcp: misc fixes for v7.2-rc6 Matthieu Baerts (NGI0)
2026-07-28 17:11 ` [PATCH net 1/5] mptcp: avoid combining some incoming suboptions Matthieu Baerts (NGI0)
2026-07-30 0:23 ` Jakub Kicinski [this message]
2026-07-30 8:14 ` Matthieu Baerts
2026-07-28 17:11 ` [PATCH net 2/5] mptcp: pm: fix data race in add_addr timer callback Matthieu Baerts (NGI0)
2026-07-28 17:11 ` [PATCH net 3/5] selftests: mptcp: join: mark tests with data corruption as failed Matthieu Baerts (NGI0)
2026-07-28 17:12 ` [PATCH net 4/5] mptcp: fastopen: only mark MPTFO subflows with SYN data Matthieu Baerts (NGI0)
2026-07-28 17:12 ` [PATCH net 5/5] mptcp: reclaim forward-allocated memory on RX path errors Matthieu Baerts (NGI0)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729172306.31deb67d@kernel.org \
--to=kuba@kernel.org \
--cc=cpaasch@openai.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).