From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7756E430CDC for ; Fri, 31 Jul 2026 14:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785509807; cv=none; b=LqBAodGhU4w+EUzcYaMsGF6VqiWBGi2K1xDc7oCYaLPa+2vhsGn6i+xAsGV9wCJYUz2lwlTXh4Dt6jdm/xtmsyIxlEcHFtAZxi/OpivGULBtYOuSHx32YSTaVDsgm2oHxqhBDLWRdbibkjxPAZ6oDuvohuh6e8riawrU5NXqt0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785509807; c=relaxed/simple; bh=hZ1YauAi3dGx8ucxhDwiFNmqYPLCrvErBB3RNfqn5t4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lsX4hiQxuA20NMB1u3Qj8bIHzIsC9tRpRBKev0IZFpRvZ2433J8QF0njoysd7+XXefG/IGKO9jqTDePweOJ9R8OXl7NZoVRV7YFKwnAPvN5BVNHUDI5iPBo/ZF490MYTj7fLeJkCm091z/8q2eSmuPiAkv3ZsUE6A4ZhGR+/u60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HQuN1V40; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HQuN1V40" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785509798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=s28ds64NKsQOrjmawHAp2UwN4M9GHd+vx61+rPxcqfo=; b=HQuN1V40wcBGQeAWO6HYoMJclcMUfnAifV3HfgjAV8Ifu97/2HP3fH119DSzQWzDcW0Lja udiW/JvqGQm5LB/fXuDL3CNmDKN6tgM0qD+Wj0dzjsk4P0XKhcaT9CzUB0BG7QnGJrzc/B 6h0/O6JYokAFWFnlz/frOTVJituafGM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-f1bjXoioMVSDs39G3OhrcQ-1; Fri, 31 Jul 2026 10:56:14 -0400 X-MC-Unique: f1bjXoioMVSDs39G3OhrcQ-1 X-Mimecast-MFC-AGG-ID: f1bjXoioMVSDs39G3OhrcQ_1785509773 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6F9C11956094; Fri, 31 Jul 2026 14:56:13 +0000 (UTC) Received: from bgrech-thinkpadp1gen3.rmtustx.csb (unknown [10.2.16.27]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 819F21956089; Fri, 31 Jul 2026 14:56:12 +0000 (UTC) From: Brian Grech To: netdev@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, Brian Grech Subject: [PATCH] selftests/net: gro: use variable sleep to handle slow environments Date: Fri, 31 Jul 2026 09:55:45 -0500 Message-ID: <20260731145545.4011291-1-bgrech@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 The server socket initialization sleep was hardcoded at 0.5 seconds. On slow or heavily loaded machines this is insufficient, causing the client to connect before the server is ready and producing spurious test failures. Respect KSFT_MACHINE_SLOW by extending the sleep to 2 seconds when set, consistent with how other selftests handle slow environments. Signed-off-by: Brian Grech --- tools/testing/selftests/net/gro.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh index 4c5144c6f652..7c0e4434fa58 100755 --- a/tools/testing/selftests/net/gro.sh +++ b/tools/testing/selftests/net/gro.sh @@ -21,12 +21,14 @@ run_test() { # Each test is run 6 times to deflake, because given the receive timing, # not all packets that should coalesce will be considered in the same flow # on every try. + local sleep_time=0.5 + [ "$KSFT_MACHINE_SLOW" = yes ] && sleep_time=2 for tries in {1..6}; do # Actual test starts here ip netns exec $server_ns ./gro "${ARGS[@]}" "--rx" "--iface" "server" \ 1>>log.txt & server_pid=$! - sleep 0.5 # to allow for socket init + sleep $sleep_time # to allow for socket init ip netns exec $client_ns ./gro "${ARGS[@]}" "--iface" "client" \ 1>>log.txt wait "${server_pid}" -- 2.55.0