From: Jakub Kicinski <kuba@kernel.org>
To: "Pablo Vallespín Aranguren" <pablopva014@gmail.com>
Cc: David Laight <david.laight.linux@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"open list:TULIP NETWORK DRIVERS" <netdev@vger.kernel.org>,
"open list:TULIP NETWORK DRIVERS" <linux-parisc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] net: tulip: xircom_cb: drop runt frames before skb copy
Date: Fri, 31 Jul 2026 16:55:55 -0700 [thread overview]
Message-ID: <20260731165555.50741429@kernel.org> (raw)
In-Reply-To: <am0L4gNtPJaMPx_9@ThinkPad-P15>
On Fri, 31 Jul 2026 22:56:02 +0200 Pablo Vallespín Aranguren wrote:
> > Have you checked that that hardware can actually set a short value?
> > I'd expect that packets shorter than 64 bytes (including the crc) are
> > dropped as 'runts' and probably don't even use a ring entry.
>
> I haven't verified how the real Xircom firmware handles runt frames (I
> don't own this hardware). I tested with Qemu's emulated NIC, the device
> itself does validate and reject negative-size values before sending them
> to the driver.
Are you related to Greg KH in any way? You use the same slop tag.
Just curious.
Please send a patch to delete this driver if you want to help.
It's ancient.
next prev parent reply other threads:[~2026-07-31 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 18:33 [PATCH] net: tulip: xircom_cb: drop runt frames before skb copy Pablo Vallespín Aranguren
2026-07-31 19:26 ` David Laight
2026-07-31 20:56 ` Pablo Vallespín Aranguren
2026-07-31 23:55 ` Jakub Kicinski [this message]
2026-08-01 7:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731165555.50741429@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablopva014@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox