From: Ali Ahmet Memis <ali@iusegentoo.com>
To: xiexinet@gmail.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org
Subject: Re: [PATCH net v3 3/4] net: hsr: unfold GSO super-packets at the forward entry
Date: Sat, 1 Aug 2026 02:58:52 +0300 [thread overview]
Message-ID: <20260731235852.204486-1-ali@iusegentoo.com> (raw)
In-Reply-To: <20260731090224.18-4-xiexinet@gmail.com>
The __skb_gso_segment() dispatch and the consume_skb() and kfree_skb()
paths look correct: the original skb is freed on success and the segment
list is freed on error, with no double free. The port type gate keeps LAN
and tagged aggregates out of software segmentation.
Reviewed-by: Ali Ahmet Memis <ali@iusegentoo.com>
next prev parent reply other threads:[~2026-07-31 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:02 [PATCH net v3 0/4] net: hsr: fix GRO/GSO super-packet handling Xin Xie
2026-07-31 9:02 ` [PATCH net v3 1/4] net: hsr: fix packet drops caused by GRO superpackets Xin Xie
2026-07-31 23:58 ` Ali Ahmet Memis
2026-07-31 9:02 ` [PATCH net v3 2/4] net: hsr: shrink seqnr_lock to sequence counter updates Xin Xie
2026-07-31 23:58 ` Ali Ahmet Memis
2026-07-31 9:02 ` [PATCH net v3 3/4] net: hsr: unfold GSO super-packets at the forward entry Xin Xie
2026-07-31 23:58 ` Ali Ahmet Memis [this message]
2026-07-31 9:02 ` [PATCH net v3 4/4] selftests: net: hsr: add GRO super-packet forwarding test Xin Xie
2026-07-31 23:59 ` Ali Ahmet Memis
2026-07-31 23:57 ` [PATCH net v3 0/4] net: hsr: fix GRO/GSO super-packet handling Ali Ahmet Memis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731235852.204486-1-ali@iusegentoo.com \
--to=ali@iusegentoo.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=xiexinet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox