From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 387562139C9 for ; Sat, 1 Aug 2026 06:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785564156; cv=none; b=gzV3YVUgaOAPjl/O3ackBwtAQMlh+tCPZIA0f7YoUfyD3h8rdzvyzUNq3BJzvdBJ6GXm1J0ePZn/vYpgO5TMu2RPipM9/atQ10BgNPd87GJuTEJaM0aTOWDjiTcjfiUQntwKoYFjI6wpz0PQgBHS09iYURLESXJdgf2Yo0Hms7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785564156; c=relaxed/simple; bh=cCRUw9Tymj8WgwK1j3rS3w2OZiOMdK3gIoxQR8pYLGM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EpyT+u6WH0FqyeaUMHMM0MPW3rKraEaAUoseBDkAxhQsG/KH28RUIufMJFJ46Fh8zSsbomicyxnjHKuInsuPJVGrkz3j3Rv/dlWiOzrmnyreAsqszX0nQNcuLVwLri/3ubrg8gTQKl7HJyb5WLjTOl5vD/kwBoGOMgw6sCbgYqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=POIogbOn; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="POIogbOn" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cecdc24b1cso1852935ad.1 for ; Fri, 31 Jul 2026 23:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785564155; x=1786168955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wG08jLgdCXnGeCo9TntB3GpQ3NVQXE5hVvOabkH8znA=; b=POIogbOnw9X+TMqiJ4lECbJyXuvQ27W8u561fswtnkQTMk1u1NnTLbw30X6DV7KrSE MGA8iQs6zhzRlnyRlA+FdpvQd/upyxOt8pAMtGM9RserjFf6tzA+eQPoxziIRWmVgbsr NLwZJasZGriMmw4wvNwKOHAuezP7cRmsuB3UgdP/rn56GcP7OUs7McyHTzRsGZ2raQtr vD8nE2xVpq4Qd6t9MSOJSGOCSDVRXM0EAa3H+CVqVEfSJSe6MQvtC+os3l88VycmCfig YiftZKHIJq20X+NrGMXPR8ZJIa4EydU6XtCdiygK6c3QG2rjparOnysWZvxquCLuf5ex JY/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785564155; x=1786168955; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wG08jLgdCXnGeCo9TntB3GpQ3NVQXE5hVvOabkH8znA=; b=sSuHVZ87GMYAZ9OAHA347+KXTRq8NMF/Io9kUIjGdZj/Fc0XC957tOU21ZQAPDXLvP NHv6g8tmKjY3zBAG5nPOapqt+GoFdYAgc66AC4/X3+Ie3pLo54ZRlj2xINydCSnVpVwX jA2f7yrU5hlbMKLkTNMmEcX5gJArdS2EZLHXMS3seYLbbYKhvFxzQyVsr8AxYdz57R/m k96MgB2aKEiAjC/XVlXVmlMUPAfu5vT21NQD+CATioI2qDnh5AlqAkAKBJbtrR7yOqs6 LwrhtcPk48uSOUIdf/JLQvwXFPyBLkDanuPj8+rXEX5onHn5jkhyS8mSjRb6mtFKdVBA dz8g== X-Gm-Message-State: AOJu0YxaJG87QvCY3up8h5J+fVjwuqCbIiI7sZhWrH0HnjJcAjbz0Qil Kb1KWrslFgK7mvu88Wl2kQ5GywOeVsuM5eF0vYsT2Ek0iy0MkBiWtMtL X-Gm-Gg: AR+sD1274ZobGaOTxbE55Nd3ltsjv8ykBZiIFgn1IQhA8g6gjJaWgUHEvzmga/I0OaY ttSRLS6Hfoxz9lGkoRjUyHxonKjMm5IAKnnbIFTqMPuh8PZ7zVP1Py04wUD2drbAEVhyntOGJAL WpmAXf5KtQ4vuhh9V0hnxdztFuprEuqvwtD+9GSoccvuWHBVq0+YpoUtlaNd1/ICuMBZceuxc1k oQbUsYLdlmpqi7BjM6cwPPCOP81v444+XS73eMN1q/9GHIIH0MGLKzxIYU5dJhFmqs8fkVJAusq p9VxKIC989UE21nGhxglwwg3rv+gmmMg1pvouIHmkhULxR13/wnhsRJe0c0B1bYsBWVRiMIXwdK /I8ClCbMrLXzhH7J1FfoNRxHD/7hrmyolNKZjtM2nF99TtL7yg2hBMSIdUg4ewSfGUyJIc9CvpT g53EDLtAy98eXG2oZe7iSP0mL3ek2SYkl6SGf+NiP0rEeqyq9Km7HcHoVcS7uR1yf1YU8YBbHSD E4ZpecQHwrpFzYjWc7aWNYW56fHNKE0g7LIy8JbEXqU30v/A10G7p8= X-Received: by 2002:a17:903:46cf:b0:2ca:ecf6:9115 with SMTP id d9443c01a7336-2d0523bcf3amr36902565ad.2.1785564154559; Fri, 31 Jul 2026 23:02:34 -0700 (PDT) Received: from localhost.localdomain (45.78.65.84.16clouds.com. [45.78.65.84]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e18e114sm22462138eec.28.2026.07.31.23.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 23:02:34 -0700 (PDT) From: Chengfeng Ye To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Richard Gobert , Xuanqiang Luo , Chengfeng Ye , Xin Long , William Tu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net] fou: ensure GUE headers have enough headroom Date: Sat, 1 Aug 2026 14:01:15 +0800 Message-ID: <20260801060115.3538849-1-nicoyip.dev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipgre_changelink() installs GUE encapsulation before it publishes the new GRE header length and updates dev->needed_headroom. The transmit path does not serialize with RTNL, so it can interleave as follows: CPU 0 (ipgre_changelink) CPU 1 (ipgre_xmit) install GUE encapsulation reserve the old needed_headroom publish larger GRE flags update tunnel->tun_hlen push the larger GRE header push the GUE and UDP headers update dev->needed_headroom With REMCSUM, the new layout can push 16 bytes of GRE and 20 bytes of GUE/UDP headers into an skb with only 32 bytes of actual headroom. The final UDP push writes four bytes before skb->head. With the update window widened, the kernel reported: skbuff: skb_under_panic: ... len:128 put:8 ... dev:gre0poc kernel BUG at net/core/skbuff.c:214! Oops: invalid opcode: 0000 [#1] SMP KASAN NOPTI Call Trace: skb_push fou_build_udp gue_build_header ip_tunnel_xmit __gre_xmit ipgre_xmit Make __gue_build_header() ensure space for both the GUE header it is about to push and the UDP header that follows. On normally sized skbs the check is a no-op. If configuration changes race with transmission, skb_cow_head() expands the head before either GUE write, or returns an error without modifying the packet. Fixes: dd9d598c6657 ("ip_gre: add the support for i/o_flags update via netlink") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5 Signed-off-by: Chengfeng Ye --- net/ipv4/fou_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c index ab09dfcdecbd..8cf0d43acb41 100644 --- a/net/ipv4/fou_core.c +++ b/net/ipv4/fou_core.c @@ -980,6 +980,8 @@ int __gue_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e, skb, 0, 0, false); hdrlen = sizeof(struct guehdr) + optlen; + if (skb_cow_head(skb, hdrlen + sizeof(struct udphdr))) + return -ENOMEM; skb_push(skb, hdrlen); -- 2.43.0