From: Ido Schimmel <idosch@nvidia.com>
To: David Lee <david.lee@trailofbits.com>
Cc: dsahern@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
Kyle Zeng <kylebot@openai.com>,
Dominik 'Disconnect3d' Czarnota
<dominik.czarnota@trailofbits.com>,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: prevent in6_dev_get() from resurrecting inet6_dev
Date: Sun, 2 Aug 2026 14:56:39 +0300 [thread overview]
Message-ID: <20260802115639.GA270646@shredder> (raw)
In-Reply-To: <20260731135202.566337-1-david.lee@trailofbits.com>
In addition to the other process comments you got, subject prefix should
have been "[PATCH net]" ("[PATCH net v2]" now). See:
https://docs.kernel.org/process/maintainer-netdev.html
Get the process right with one patch, then send the rest.
On Fri, Jul 31, 2026 at 01:52:01PM +0000, David Lee wrote:
> in6_dev_get() reads dev->ip6_ptr under RCU and then unconditionally
> increments its refcount. Device teardown can clear the pointer and drop
> the last reference between these operations. The increment then
> resurrects an object whose RCU free has already been queued, so callers
> can use it after it is freed.
>
> Use refcount_inc_not_zero() and return NULL when the object has already
> reached zero. RCU keeps the memory accessible through the attempted
> reference acquisition, and a successful increment pins the object for
> the caller.
>
> Fixes: 8814c4b53381 ("[IPV6] ADDRCONF: Convert addrconf_lock to RCU.")
> Bug found and triaged by OpenAI Security Research and
> validated by Trail of Bits.
>
> Assisted-by: Codex:gpt-5.6-sol gpt-5.5-cyber
> Signed-off-by: Kyle Zeng <kylebot@openai.com>
> ---
> Trail of Bits has a reproducer for this bug that triggers
> a KASAN use-after-free and can share if needed.
Didn't you see an "addition on 0; use-after-free" trace before KASAN?
Please include it in the commit message.
Was the bug reproduced on an unpatched kernel?
Also, what about IPv4? in_dev_get() has the same structure and at least
inet_netconf_get_devconf() is calling it without holding RTNL.
prev parent reply other threads:[~2026-08-02 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 13:52 [PATCH] ipv6: prevent in6_dev_get() from resurrecting inet6_dev David Lee
2026-08-02 8:39 ` Sven Eckelmann
2026-08-02 11:56 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802115639.GA270646@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=david.lee@trailofbits.com \
--cc=dominik.czarnota@trailofbits.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kylebot@openai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox