From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3569B33937F for ; Mon, 3 Aug 2026 15:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785772273; cv=none; b=iEIN5EqrUKOLAtmOFbnsn3+Ldqioxo+p1K8nofBHonhbt2y4H76cnY6stwd/Vcd0B+1d+7c++c69RG/tBxnGwsOycTaAK9czIeU/S/kjHXFCorwnF2JepLzkg1k0xQGXScvAyLvie/kayOEfqjf2tOprTi9eUoP6TWoTrO+nSYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785772273; c=relaxed/simple; bh=5UVMqz9ifbUcVmfoiJVWCbJshAAjsO99SAdP3jQDmR4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZLjydvTAlcPbntsidkvQIiDtpUYz6LC9P0EqV6saAtUrQjKUlSJFEG6DJd8pEh3qDHpSvFId6v/nOdJyr66Lq8EOu8JgkkS7SJg72VAv4KDi5D21skTklUX7cvxVTcYRG9UEnCTkBfGIp7/JpOsmNccysFkShVdkTL4cWrilE7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZA/c/iLL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nLUDCkHf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZA/c/iLL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nLUDCkHf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785772270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XFUzp4dc+/cQvvo30PRAIxZxQ2fHhdOz96PJlHT4h/8=; b=ZA/c/iLLPl1Dtym/m4WfFuvYivGB3akkAM7RKl2DYjLdC10RzMp0sGMpwzk8CjJMYu27wP dtVGh7sSsRdPc1VpCCfGxLpw3q1yi08YIh0li6aeWeb7U9w7NUCneKZpezzb5DXvEfUug1 sGru5ljrBwn/JyrVz/D+Z4+4JSqyIKw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-lD-JhN3JN5S9sjAS-DHRjA-1; Mon, 03 Aug 2026 11:51:08 -0400 X-MC-Unique: lD-JhN3JN5S9sjAS-DHRjA-1 X-Mimecast-MFC-AGG-ID: lD-JhN3JN5S9sjAS-DHRjA_1785772268 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47f810c8aebso2184489f8f.2 for ; Mon, 03 Aug 2026 08:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785772268; x=1786377068; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XFUzp4dc+/cQvvo30PRAIxZxQ2fHhdOz96PJlHT4h/8=; b=nLUDCkHfy1KBq/HvoqY7JkrAhDVYvGQlHqkl4m6LJYXSp3D/frKIvJphTJ/aPkvkk2 0ch/Mm9tpB/HcJETSoUqPsj5H/WdmUeDCTkyxHt5U5Hms0a4JuOTppqq4u5JlIpbL1lG /ICRlyi86EqRw/v0YyadSDfEMEulFwsEo7ojR0Zsz+CvEkUqYIEwuGJ8jkRrlaOE97Hu 1Lih/XNdutOmgHgKEuMUWLvZ1iNHGjXt13+xOeDpkbI3Rgg7d3mkvjD/lYVeXRULQ/Su vvYe+sd64G6oio5erv7y0EpiWRBgIH45DB8g6BejBl8cByrgQ+vjIxg6eEXR3tzwEeXy jMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785772268; x=1786377068; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XFUzp4dc+/cQvvo30PRAIxZxQ2fHhdOz96PJlHT4h/8=; b=QgQ9xZL28L0DBfjraNRLqj8AvNifraW6CB4xUF8jpLuO71vsF4Rt0OCXDDiIwdyJuM HKOqXL6PDO2+QNYZpwNYGS7w4700zT1PNK6SwjjwdxoZiNXqBSZR5R02l7jqIf3Vk0za VjZ7admtUWQ6uOZNMu+94g+fUoWRBrCXiCZEXNlp1+64XKRZIOwZiIUicq3HpbLpjLuF XGN13d4jLMRZQRxfoIHs1JhWloGusqjKk+9VRxxfbu8OWHiEp6DQErFYXf/d5YrcbDP6 3WcfTcB+FCnTGV6vbB9r09OjVr0bD/NhUiBWBJemDSghXSU0Jy+Zs7LDE/8FGh3JSd6J ah8A== X-Gm-Message-State: AOJu0Yy9iywf5+cb8vdjhKPGouBG3joW9F06MUkYyWDwCrZfxCEnhlM9 J4h200yYhXrtpaWIZtQYcwpQCGaD2IVWsFACvOwjhz9qPdaav2Zt3SH2kzhArpxj6shwJvUZ3z+ WY2wsSR6eFtWHDFYcrHPtsb8zh32JW0MbijN0PmOxiWl9aYApJTtzgDrgug== X-Gm-Gg: AR+sD12QSsiri59SfFLLSESoPEgDozWkCwMtP/OOfHpohT/XV8A5yafocI8NdYNs2Jj 1O69fPv3ZDw5qdkHIEccwhGmlcayOX6/2Tv2I+kFbFehJv84fFRcQO0Q84+LzPxPLim3WI4laG2 zB6PQVhFpXZcOOwa1LrtQH0CiQ6RMc1DdGThZdIWrWdekCbggrBUIohk/1CEO4veDyA6LJioCU7 UgxgoQUnhoYJ7UQ17tkK2bAzUoMylHm4loh0720bcBtD4OASG0dLcjMI6OZKOwBTNQe4Xe5Wr79 Xk0i1FsNBBQL5BaLH6ZLPrYu+1baIoV/m05t3zm1WsSmBxIs/iyfukuWOeOgL2G0WRaEo0/H+gp GoUgOamy/kLJElfxh1clVvw== X-Received: by 2002:a05:6000:184b:b0:47f:9171:bca2 with SMTP id ffacd0b85a97d-47fd72e9a25mr26624613f8f.27.1785772267536; Mon, 03 Aug 2026 08:51:07 -0700 (PDT) X-Received: by 2002:a05:6000:184b:b0:47f:9171:bca2 with SMTP id ffacd0b85a97d-47fd72e9a25mr26624518f8f.27.1785772266917; Mon, 03 Aug 2026 08:51:06 -0700 (PDT) Received: from redhat.com (IGLD-80-230-28-14.inter.net.il. [80.230.28.14]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd64eef60sm29191583f8f.16.2026.08.03.08.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 08:51:06 -0700 (PDT) Date: Mon, 3 Aug 2026 11:51:03 -0400 From: "Michael S. Tsirkin" To: Shahar Shitrit Cc: netdev@vger.kernel.org, jasowang@redhat.com, pabeni@redhat.com, virtualization@lists.linux.dev, parav@nvidia.com, yohadt@nvidia.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgg@ziepe.ca, kevin.tian@intel.com, kuba@kernel.org, andrew+netdev@lunn.ch, edumazet@google.com, danielj@nvidia.com Subject: Re: [PATCH net-next v21 05/13] virtio_net: Query and set flow filter caps Message-ID: <20260803114115-mutt-send-email-mst@kernel.org> References: <20260803140721.1871678-1-shshitrit@nvidia.com> <20260803140721.1871678-6-shshitrit@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260803140721.1871678-6-shshitrit@nvidia.com> On Mon, Aug 03, 2026 at 05:07:13PM +0300, Shahar Shitrit wrote: > When probing a virtnet device, attempt to read the flow filter > capabilities. In order to use the feature the caps must also > be set. For now setting what was read is sufficient. > > This patch adds uapi definitions virtio_net flow filters define in > version 1.4 of the VirtIO spec. > > Signed-off-by: Daniel Jurgens > Reviewed-by: Parav Pandit > Signed-off-by: Shahar Shitrit > --- > drivers/net/virtio_net.c | 239 +++++++++++++++++++++++++++++ > include/uapi/linux/virtio_net_ff.h | 91 +++++++++++ > 2 files changed, 330 insertions(+) > create mode 100644 include/uapi/linux/virtio_net_ff.h > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 3e2a5876c6c8..0d1f5a6cfd12 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -27,6 +27,11 @@ > #include > #include > #include > +#include > +#include > +#include > +#include why would virtio net need pci macros? > +#include > > static int napi_weight = NAPI_POLL_WEIGHT; > module_param(napi_weight, int, 0444); > @@ -282,6 +287,14 @@ static const struct virtnet_stat_desc virtnet_stats_tx_speed_desc_qstat[] = { > VIRTNET_STATS_DESC_TX_QSTAT(speed, ratelimit_packets, hw_drop_ratelimits), > }; > > +struct virtnet_ff { > + struct virtio_device *vdev; > + bool ff_supported; > + struct virtio_net_ff_cap_data *ff_caps; > + struct virtio_net_ff_cap_mask_data *ff_mask; > + struct virtio_net_ff_actions *ff_actions; > +}; > + > #define VIRTNET_Q_TYPE_RX 0 > #define VIRTNET_Q_TYPE_TX 1 > #define VIRTNET_Q_TYPE_CQ 2 > @@ -474,6 +487,8 @@ struct virtnet_info { > > struct virtio_net_rss_config_hdr *rss_hdr; > > + struct virtnet_ff ff; > + > /* Must be last as it ends in a flexible-array member. */ > TRAILING_OVERLAP(struct virtio_net_rss_config_trailer, rss_trailer, hash_key_data, > u8 rss_hash_key_data[NETDEV_RSS_KEY_LEN]; > @@ -519,6 +534,7 @@ static struct sk_buff *virtnet_skb_append_frag(struct receive_queue *rq, > static void virtnet_xsk_completed(struct send_queue *sq, int num); > static void free_unused_bufs(struct virtnet_info *vi); > static void virtnet_del_vqs(struct virtnet_info *vi); > +static void remove_vq_common(struct virtnet_info *vi); > > enum virtnet_xmit_type { > VIRTNET_XMIT_TYPE_SKB, > @@ -5710,6 +5726,199 @@ static const struct netdev_stat_ops virtnet_stat_ops = { > .get_base_stats = virtnet_get_base_stats, > }; > > +static size_t get_mask_size(u16 type) > +{ > + switch (type) { > + case VIRTIO_NET_FF_MASK_TYPE_ETH: > + return sizeof(struct ethhdr); > + case VIRTIO_NET_FF_MASK_TYPE_IPV4: > + return sizeof(struct iphdr); > + case VIRTIO_NET_FF_MASK_TYPE_IPV6: > + return sizeof(struct ipv6hdr); > + case VIRTIO_NET_FF_MASK_TYPE_TCP: > + return sizeof(struct tcphdr); > + case VIRTIO_NET_FF_MASK_TYPE_UDP: > + return sizeof(struct udphdr); > + } > + > + return 0; > +} > + > +static int virtnet_ff_init(struct virtnet_ff *ff, struct virtio_device *vdev) > +{ > + size_t ff_mask_size = sizeof(struct virtio_net_ff_cap_mask_data) + > + sizeof(struct virtio_net_ff_selector) * > + VIRTIO_NET_FF_MASK_TYPE_MAX; > + struct virtio_admin_cmd_query_cap_id_result *cap_id_list; > + struct virtio_net_ff_selector *sel; > + unsigned long sel_types = 0; > + size_t real_ff_mask_size; > + int err; > + int i; > + > + if (!vdev->config->admin_cmd_exec) > + return -EOPNOTSUPP; > + > + cap_id_list = kzalloc(sizeof(*cap_id_list), GFP_KERNEL); > + if (!cap_id_list) > + return -ENOMEM; > + > + err = virtio_admin_cap_id_list_query(vdev, cap_id_list); > + if (err) > + goto err_cap_list; > + > + if (!(VIRTIO_CAP_IN_LIST(cap_id_list, > + VIRTIO_NET_FF_RESOURCE_CAP) && > + VIRTIO_CAP_IN_LIST(cap_id_list, > + VIRTIO_NET_FF_SELECTOR_CAP) && > + VIRTIO_CAP_IN_LIST(cap_id_list, > + VIRTIO_NET_FF_ACTION_CAP))) { > + err = -EOPNOTSUPP; > + goto err_cap_list; > + } > + > + ff->ff_caps = kzalloc(sizeof(*ff->ff_caps), GFP_KERNEL); > + if (!ff->ff_caps) { > + err = -ENOMEM; > + goto err_cap_list; > + } > + > + err = virtio_admin_cap_get(vdev, > + VIRTIO_NET_FF_RESOURCE_CAP, > + ff->ff_caps, > + sizeof(*ff->ff_caps)); > + > + if (err) > + goto err_ff; > + > + if (!le32_to_cpu(ff->ff_caps->groups_limit) || > + !le32_to_cpu(ff->ff_caps->classifiers_limit) || > + !le32_to_cpu(ff->ff_caps->rules_limit) || > + !le32_to_cpu(ff->ff_caps->rules_per_group_limit)) { I am not sure why do we validate these specifically. Should we then validate selectors_per_classifier_limit too? > + err = -EINVAL; > + goto err_ff; > + } > + > + /* VIRTIO_NET_FF_MASK_TYPE start at 1 */ > + for (i = 1; i <= VIRTIO_NET_FF_MASK_TYPE_MAX; i++) > + ff_mask_size += get_mask_size(i); > + > + ff->ff_mask = kzalloc(ff_mask_size, GFP_KERNEL); > + if (!ff->ff_mask) { > + err = -ENOMEM; > + goto err_ff; > + } > + > + err = virtio_admin_cap_get(vdev, > + VIRTIO_NET_FF_SELECTOR_CAP, > + ff->ff_mask, > + ff_mask_size); > + > + if (err) > + goto err_ff_mask; > + > + ff->ff_mask->count = min_t(u8, ff->ff_mask->count, > + VIRTIO_NET_FF_MASK_TYPE_MAX); > + > + ff->ff_actions = kzalloc(sizeof(*ff->ff_actions) + > + VIRTIO_NET_FF_ACTION_MAX, > + GFP_KERNEL); > + if (!ff->ff_actions) { > + err = -ENOMEM; > + goto err_ff_mask; > + } > + > + err = virtio_admin_cap_get(vdev, > + VIRTIO_NET_FF_ACTION_CAP, > + ff->ff_actions, > + sizeof(*ff->ff_actions) + VIRTIO_NET_FF_ACTION_MAX); > + > + if (err) > + goto err_ff_action; > + > + ff->ff_actions->count = min_t(u8, ff->ff_actions->count, > + VIRTIO_NET_FF_ACTION_MAX); and here, do we validate count != 0? > + err = virtio_admin_cap_set(vdev, > + VIRTIO_NET_FF_RESOURCE_CAP, > + ff->ff_caps, > + sizeof(*ff->ff_caps)); > + if (err) > + goto err_ff_action; > + > + real_ff_mask_size = sizeof(struct virtio_net_ff_cap_mask_data); > + sel = (void *)&ff->ff_mask->selectors; > + > + for (i = 0; i < ff->ff_mask->count; i++) { > + /* If the selector type is unknown it may indicate the spec > + * has been revised to include new types of selectors > + */ > + if (!sel->type || sel->type > VIRTIO_NET_FF_MASK_TYPE_MAX) > + break; > + > + if (sel->length != get_mask_size(sel->type) || > + test_and_set_bit(sel->type, &sel_types)) { > + WARN_ON_ONCE(true); given we gracefully fail, I'm not sure WARN is justified, since we don't warn in other validation steps. However > + err = -EINVAL; the error here is on the device side, not user side, right? maybe a distinct error to indicate this. > + goto err_ff_action; > + } > + real_ff_mask_size += sizeof(*sel) + sel->length; > + if (real_ff_mask_size > ff_mask_size) { > + WARN_ON_ONCE(true); > + err = -EINVAL; > + goto err_ff_action; > + } > + sel = (void *)sel + sizeof(*sel) + sel->length; > + } > + ff->ff_mask->count = i; > + > + err = virtio_admin_cap_set(vdev, > + VIRTIO_NET_FF_SELECTOR_CAP, > + ff->ff_mask, > + real_ff_mask_size); > + if (err) > + goto err_ff_action; > + > + err = virtio_admin_cap_set(vdev, > + VIRTIO_NET_FF_ACTION_CAP, > + ff->ff_actions, > + sizeof(*ff->ff_actions) + VIRTIO_NET_FF_ACTION_MAX); why not ff->ff_mask->count? this is all we initialized... > + if (err) > + goto err_ff_action; > + > + ff->vdev = vdev; > + ff->ff_supported = true; > + > + kfree(cap_id_list); > + > + return 0; > + > +err_ff_action: > + kfree(ff->ff_actions); > + ff->ff_actions = NULL; > +err_ff_mask: > + kfree(ff->ff_mask); > + ff->ff_mask = NULL; > +err_ff: > + kfree(ff->ff_caps); > + ff->ff_caps = NULL; > +err_cap_list: > + kfree(cap_id_list); > + > + return err; > +} > + > +static void virtnet_ff_cleanup(struct virtnet_ff *ff) > +{ > + if (!ff->ff_supported) > + return; > + > + kfree(ff->ff_actions); > + kfree(ff->ff_mask); > + kfree(ff->ff_caps); > + ff->ff_supported = false; > +} > + > static void virtnet_freeze_down(struct virtio_device *vdev) > { > struct virtnet_info *vi = vdev->priv; > @@ -5728,6 +5937,10 @@ static void virtnet_freeze_down(struct virtio_device *vdev) > netif_tx_lock_bh(vi->dev); > netif_device_detach(vi->dev); > netif_tx_unlock_bh(vi->dev); > + > + rtnl_lock(); > + virtnet_ff_cleanup(&vi->ff); > + rtnl_unlock(); > } > > static int init_vqs(struct virtnet_info *vi); > @@ -5757,9 +5970,24 @@ static int virtnet_restore_up(struct virtio_device *vdev) > goto err_destroy_pools; > } > > + /* > + * Initialize flow filters. Not supported is an acceptable and common > + * return code > + */ > + rtnl_lock(); > + err = virtnet_ff_init(&vi->ff, vi->vdev); > + if (err && err != -EOPNOTSUPP) { > + rtnl_unlock(); > + virtnet_freeze_down(vi->vdev); > + remove_vq_common(vi); > + return err; > + } > + rtnl_unlock(); > + > netif_tx_lock_bh(vi->dev); > netif_device_attach(vi->dev); > netif_tx_unlock_bh(vi->dev); > + > return 0; > > err_destroy_pools: > @@ -7043,6 +7271,15 @@ static int virtnet_probe(struct virtio_device *vdev) > > virtio_device_ready(vdev); > > + /* Initialize flow filters. Not supported is an acceptable and common > + * return code > + */ > + err = virtnet_ff_init(&vi->ff, vi->vdev); > + if (err && err != -EOPNOTSUPP) { > + rtnl_unlock(); > + goto free_unregister_netdev; > + } > + > if (vi->has_rss || vi->has_rss_hash_report) { > if (!virtnet_commit_rss_command(vi)) { > dev_warn(&vdev->dev, "RSS disabled because committing failed.\n"); > @@ -7125,6 +7362,7 @@ static int virtnet_probe(struct virtio_device *vdev) > > free_unregister_netdev: > unregister_netdev(dev); > + virtnet_ff_cleanup(&vi->ff); > free_failover: > net_failover_destroy(vi->failover); > free_page_pools: > @@ -7175,6 +7413,7 @@ static void virtnet_remove(struct virtio_device *vdev) > virtnet_free_irq_moder(vi); > > unregister_netdev(vi->dev); > + virtnet_ff_cleanup(&vi->ff); > > net_failover_destroy(vi->failover); > > diff --git a/include/uapi/linux/virtio_net_ff.h b/include/uapi/linux/virtio_net_ff.h > new file mode 100644 > index 000000000000..f9e771a0baff > --- /dev/null > +++ b/include/uapi/linux/virtio_net_ff.h > @@ -0,0 +1,91 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note > + * > + * Header file for virtio_net flow filters > + */ > +#ifndef _LINUX_VIRTIO_NET_FF_H > +#define _LINUX_VIRTIO_NET_FF_H > + > +#include > +#include > + > +#define VIRTIO_NET_FF_RESOURCE_CAP 0x800 > +#define VIRTIO_NET_FF_SELECTOR_CAP 0x801 > +#define VIRTIO_NET_FF_ACTION_CAP 0x802 > + > +/** > + * struct virtio_net_ff_cap_data - Flow filter resource capability limits > + * @groups_limit: maximum number of flow filter groups supported by the device > + * @classifiers_limit: maximum number of classifiers supported by the device > + * @rules_limit: maximum number of rules supported device-wide across all groups > + * @rules_per_group_limit: maximum number of rules allowed in a single group > + * @last_rule_priority: priority value associated with the lowest-priority rule > + * @selectors_per_classifier_limit: maximum selectors allowed in one classifier > + */ > +struct virtio_net_ff_cap_data { > + __le32 groups_limit; > + __le32 classifiers_limit; > + __le32 rules_limit; > + __le32 rules_per_group_limit; > + __u8 last_rule_priority; > + __u8 selectors_per_classifier_limit; > + /* private: */ > + __u8 reserved[2]; > +}; > + > +/** > + * struct virtio_net_ff_selector - Selector mask descriptor > + * @type: selector type, one of VIRTIO_NET_FF_MASK_TYPE_* constants > + * @flags: selector flags, see VIRTIO_NET_FF_MASK_F_* constants > + * @reserved: must be set to 0 by the driver and ignored by the device > + * @length: size in bytes of @mask > + * @reserved1: must be set to 0 by the driver and ignored by the device > + * @mask: variable-length mask payload for @type, length given by @length > + * > + * A selector describes a header mask that a classifier can apply. The format > + * of @mask depends on @type. > + */ > +struct virtio_net_ff_selector { > + __u8 type; > + __u8 flags; > + __u8 reserved[2]; > + __u8 length; > + __u8 reserved1[3]; > + __u8 mask[] __counted_by(length); > +}; > + > +#define VIRTIO_NET_FF_MASK_TYPE_ETH 1 > +#define VIRTIO_NET_FF_MASK_TYPE_IPV4 2 > +#define VIRTIO_NET_FF_MASK_TYPE_IPV6 3 > +#define VIRTIO_NET_FF_MASK_TYPE_TCP 4 > +#define VIRTIO_NET_FF_MASK_TYPE_UDP 5 > +#define VIRTIO_NET_FF_MASK_TYPE_MAX VIRTIO_NET_FF_MASK_TYPE_UDP > + > +/** > + * struct virtio_net_ff_cap_mask_data - Supported selector mask formats > + * @count: number of entries in @selectors > + * @reserved: must be set to 0 by the driver and ignored by the device > + * @selectors: packed array of struct virtio_net_ff_selector. > + */ > +struct virtio_net_ff_cap_mask_data { > + __u8 count; > + __u8 reserved[7]; > + __u8 selectors[]; > +}; > + > +#define VIRTIO_NET_FF_MASK_F_PARTIAL_MASK (1 << 0) > + > +#define VIRTIO_NET_FF_ACTION_DROP 1 > +#define VIRTIO_NET_FF_ACTION_RX_VQ 2 > +#define VIRTIO_NET_FF_ACTION_MAX VIRTIO_NET_FF_ACTION_RX_VQ > +/** > + * struct virtio_net_ff_actions - Supported flow actions > + * @count: number of supported actions in @actions > + * @reserved: must be set to 0 by the driver and ignored by the device > + * @actions: array of action identifiers (VIRTIO_NET_FF_ACTION_*) > + */ > +struct virtio_net_ff_actions { > + __u8 count; > + __u8 reserved[7]; > + __u8 actions[] __counted_by(count); > +}; > +#endif > -- > 2.49.0