From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E49411FB1 for ; Mon, 3 Aug 2026 14:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766671; cv=none; b=pxTfB4YfVEzSm4PrmBz+I4iTGEzsGJcEr1gPOXxDgN3FXvQaPv8mXn1ma9gSLRzTmeZz31fV/b3WdDZa8+RiGjpJG6f3Q9cBfjyf/S+fyL3925EshfFJpuX0je9vIRIu0xVhcWLHzqZzHaZEDzdbrWtt1fyfRbiAX8tOBsY8Rug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766671; c=relaxed/simple; bh=q1Uz+Gm71OPt/zJsTxyArW2pEOjZRyhgf2I4biF/dNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GYFgk+VjU+rNc5EMHW5zFUeal/w0Q/bAiffDoLuXuRRORReyPjqdn857M0rcj2N6/liAuee1sJbPpTbxtnVl9cwXgfJASpp6kKflg4mq0dIHfRvplzMKOzKcRXPGpzsTgEB1wo07WH7EXRTT6pfaSl9ghI1uNuJuoPjnu5oPLUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mGG62n+g; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mGG62n+g" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so3469931a91.3 for ; Mon, 03 Aug 2026 07:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766669; x=1786371469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iWp6MzQC1qDygJL4OCtM1qnllOHL0djYegVbWv/i/KI=; b=mGG62n+gxE57o+8qRAEcvglTLaHHxWqsRO2gbcsY3lopfDIO7ynotl6PvKeHun06CS xC8fGyYSlpPAceQ7AL3qvtDlAGz1dBj5JVgSfaXpyIvFAvakseHsxtYS+2LUHGmmwpLd dl1iqbYxwpPkLt665JTbDu76QziLMQy+HR7I9lBNPTAeiwboxCdKISVzC80kGgP8Qj5h bf81nGvYBRIjyWlACQwsHrbmmAes2Cyo2vFOD9OhiSvfFmDI3l75M0iFy4DJjAB49Sdp o2AY/ke65dcrhEBFzsupDdSYh9m4NOfnpAqeoy3yvCqi39HNu/11DsOTaFzRQ9MNiB2b pn7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766669; x=1786371469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iWp6MzQC1qDygJL4OCtM1qnllOHL0djYegVbWv/i/KI=; b=RHKL1Z5QGdELsNmFlFIMu2pkrVNwjoBQwqK3cyR6Hrm5DMw1BLeIC7qS2p394GBdtH I+3YRBUN3ieZexGCnzkqfnqc5zU350poaSqZhtBim4v58giBJPagxFNeC7mEFJ6ybpt/ ruYNJC7VNjBJ4PiPMY4m1F8F8o1Jo4rIeZ6hyOOA+t2O8Fv93Zpgxsq6bPWm5DorMA+Y HfcVGAvH2bKLsBoHWnlYgGz456ocgZrJq8wzWgm1I61ITES2JRop67UKmhnK0NHxQlir jG9cYNsTDnGm9q65MyPniaMh6PJ3B4BZf93A1OMQklUKhIv0MT1PkjrPy5XBgYpQ7tBa 5EHA== X-Forwarded-Encrypted: i=1; AHgh+Rr8amw/XkPrdgSQi3vykxovIuv3LHE9erNdIc/7T8DbFFkFWhYAyxYHf4Ej3f7ho6zPp29l47M=@vger.kernel.org X-Gm-Message-State: AOJu0YyUO9qm47P32MmJVRVLhelEnirm1mlALKyVi/SgHeABVnLYoLMJ 8c6W8/bB0mOzUcQzzphRbfE8skLDu3F6zTScYm/ro8Cci5O92vJBHhim X-Gm-Gg: AR+sD13XnJ02QYbBNYamsdsBdqslJqbfE3bbkLu3iSsbENJ9UpG1omSav8IQtIEQkZI yStKABgI245IjjFuYPydOkG8cZkbv4KwJTlkjaHyK8JMC4bJ+PdUWHfr8JxtXrCWh2zLScyPxsp 8fBrkKPNW6e4JQYDtMn0Wv15Zm0cf0tqEMS0zoRCGsXpzZ+XfAd0JCvdTAftJsuobpGMyu4Ycio dLjnuSYDa3HNfGrYIYR/J51EeE8a1i1DTZHcO1ppFPCB/xzOiE5ZoTWujR/YPm+V3s9bPDbs7PT 3zuyTAeFXY4JNHHtAMpUrYuAtJ2ug95hBtYIMUVZfzLj9iysqJmmEt0Wg88yRDGKVWYqGDAsaa8 EjF3DTFWtUZ01USgJD5cFKHqamHeL1GA6fIZsWDkqsQy7H/U2pbp2YQ24iHVqdxpAPmkVAGHCYd oik9w0SMTOH8CTz5eWwEtEUevuWoMmIh1u1HNcRb9MrXudiiB5mFDsIN2WIEPl/UPaeKGtxfmdO SDnU1rMreJhTt80gwDa X-Received: by 2002:a17:90b:528c:b0:37f:9ce1:7364 with SMTP id 98e67ed59e1d1-38fbc4d5e09mr9059524a91.26.1785766669331; Mon, 03 Aug 2026 07:17:49 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb30dff2esm4078462a91.13.2026.08.03.07.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:17:49 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Chen-Yu Tsai , Akari Tsuyukusa , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_)), stable@vger.kernel.org Subject: [PATCH 05/32] clk: mediatek: mt8173: fix memory leak on module removal Date: Mon, 3 Aug 2026 23:16:32 +0900 Message-ID: <20260803141659.559129-6-akkun11.open@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com> References: <20260803141659.559129-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk-mt8173-apmixedsys.c and clk-mt8173-infracfg.c do not call platform_set_drvdata() during their driver probe callback, but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and allow module build") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa --- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c index d7d416172ab3..65dc4489a09c 100644 --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c @@ -179,6 +179,8 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) if (r) goto unregister_ref2usb; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_ref2usb: diff --git a/drivers/clk/mediatek/clk-mt8173-infracfg.c b/drivers/clk/mediatek/clk-mt8173-infracfg.c index fa2d1d557e04..9b8c35897789 100644 --- a/drivers/clk/mediatek/clk-mt8173-infracfg.c +++ b/drivers/clk/mediatek/clk-mt8173-infracfg.c @@ -128,6 +128,8 @@ static int clk_mt8173_infracfg_probe(struct platform_device *pdev) if (r) goto unregister_clk_hw; + platform_set_drvdata(pdev, infra_clk_data); + return 0; unregister_clk_hw: -- 2.55.0