From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, kerneljasonxing@gmail.com, kuniyu@google.com,
bjorn@kernel.org, jiayuan.chen@linux.dev, kaiyuanz@google.com,
willemb@google.com, asml.silence@gmail.com, sdf@fomichev.me,
bobbyeshleman@gmail.com, fw@strlen.de,
Neal Cardwell <ncardwell@google.com>,
Ralf Lici <ralf@mandelbit.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH net v2 2/3] net: devmem: return EMSGSIZE on type mismatch
Date: Tue, 4 Aug 2026 14:38:46 -0700 [thread overview]
Message-ID: <20260804143846.6fb87860@kernel.org> (raw)
In-Reply-To: <CAHS8izMK_GNTmoUnkNB4iJv-7msx0F+vugg+-dTCcyRxyk3YQA@mail.gmail.com>
On Tue, 4 Aug 2026 08:36:40 -0700 Mina Almasry wrote:
> On Mon, Aug 3, 2026 at 12:54 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Mon, 3 Aug 2026 17:14:40 +0000 Mina Almasry wrote:
> > > When a devmem payload mixes with a standard page payload, return
> > > -EMSGSIZE instead of -EFAULT. This enables tcp_sendmsg to seamlessly
> > > fall back to creating a new segment instead of failing the socket send.
> >
> > Sure but AFAIU this was discovered during a ML discussion,
> > so the change is an improvement for net-next rather than a fix.
> > Do you have any reason to believe that real applications hit
> > the error?
>
> No, I don't have a reason; I just thought it was a straightforward fix
> you might want to take in net. I can definitely punt this to net-next.
> I'm a bit unsure whether you want this series reposted as v3 without
> this patch, or if you're going to take the other 2 patches. I guess if
> I don't see the rest merged I'll repost. Thanks!
split and repost please
next prev parent reply other threads:[~2026-08-04 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 17:14 [PATCH net v2 1/3] net: core: propagate unreadable flag in skb_zerocopy Mina Almasry
2026-08-03 17:14 ` [PATCH net v2 2/3] net: devmem: return EMSGSIZE on type mismatch Mina Almasry
2026-08-03 17:32 ` Bobby Eshleman
2026-08-03 19:54 ` Jakub Kicinski
2026-08-04 15:36 ` Mina Almasry
2026-08-04 21:38 ` Jakub Kicinski [this message]
2026-08-03 17:14 ` [PATCH net v2 3/3] net: tcp: block standard payload injection into devmem skbs Mina Almasry
2026-08-03 17:35 ` Bobby Eshleman
2026-08-03 17:31 ` [PATCH net v2 1/3] net: core: propagate unreadable flag in skb_zerocopy Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804143846.6fb87860@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=bjorn@kernel.org \
--cc=bobbyeshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kaiyuanz@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sdf@fomichev.me \
--cc=will@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox