From: Jakub Kicinski <kuba@kernel.org>
To: Minhong He <heminhong@kylinos.cn>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Dmitry Skorodumov <dskr99@gmail.com>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ipvlan: check register_netdevice_notifier() error in ipvlan_init_module()
Date: Tue, 4 Aug 2026 18:57:06 -0700 [thread overview]
Message-ID: <20260804185706.49149c53@kernel.org> (raw)
In-Reply-To: <20260803090007.142517-1-heminhong@kylinos.cn>
On Mon, 3 Aug 2026 17:00:07 +0800 Minhong He wrote:
> - register_netdevice_notifier(&ipvlan_notifier_block);
> + err = register_netdevice_notifier(&ipvlan_notifier_block);
> + if (err)
> + return err;
> #if IS_ENABLED(CONFIG_IPV6)
> register_inet6addr_notifier(&ipvlan_addr6_notifier_block);
> register_inet6addr_validator_notifier(
You should error check these as well while at it?
prev parent reply other threads:[~2026-08-05 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 9:00 [PATCH net] net: ipvlan: check register_netdevice_notifier() error in ipvlan_init_module() Minhong He
2026-08-05 1:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804185706.49149c53@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dskr99@gmail.com \
--cc=edumazet@google.com \
--cc=heminhong@kylinos.cn \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox