From: Qihang <q.h.hack.winter@gmail.com>
To: netdev@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, willemb@google.com,
daniel.zahka@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
stable@vger.kernel.org, Qihang Tang <q.h.hack.winter@gmail.com>
Subject: [PATCH net v6 0/3] net: fix hard_header_len races in packet send paths
Date: Wed, 5 Aug 2026 20:57:26 +0800 [thread overview]
Message-ID: <20260805125729.19220-1-q.h.hack.winter@gmail.com> (raw)
From: Qihang Tang <q.h.hack.winter@gmail.com>
The packet socket TX paths read dev->hard_header_len independently for
skb allocation and header construction. Concurrent netdevice
reconfiguration (e.g. bonding device type changes) can change this value
in between, leading to mismatched headroom and copy length, and in the
SOCK_RAW case to out-of-bounds writes.
Patch 1 removes the CAP_SYS_RAWIO zero-padding branch in
dev_validate_header(). That branch sizes a memset against the live
dev->hard_header_len while operating on an skb whose headroom was
allocated from an earlier hard_header_len read, so a concurrent increase
can write past the reserved buffer. Removing it first keeps the later
snapshot fixes bisect-safe: they do not replace an earlier skb_under_panic
with a silent overwrite.
Patches 2 and 3 snapshot hard_header_len once per send and use it
consistently for allocation and construction, in the non-ring and TX_RING
paths respectively. The separate SOCK_DGRAM consistency problem between
hard_header_len and header_ops->create remains out of scope, as noted in
the commit messages.
v5 -> v6:
- Fix Signed-off-by to use full name (DCO).
- Add patch 1: remove CAP_SYS_RAWIO zero-padding in dev_validate_header,
before the snapshot fixes for per-commit safety. Suggested by Willem de
Bruijn.
- Add Reviewed-by from Willem de Bruijn to the TX_RING patch (given on v5).
v5: https://lore.kernel.org/netdev/20260730082925.93759-1-q.h.hack.winter@gmail.com/
Qihang Tang (3):
net: remove CAP_SYS_RAWIO zero-padding in dev_validate_header
packet: use consistent hard_header_len in non-ring send paths
packet: use consistent hard_header_len in TX_RING send path
include/linux/netdevice.h | 11 ++++------
net/packet/af_packet.c | 45 +++++++++++++++++++++++----------------
2 files changed, 31 insertions(+), 25 deletions(-)
--
2.50.1 (Apple Git-155)
next reply other threads:[~2026-08-05 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 12:57 Qihang [this message]
2026-08-05 12:57 ` [PATCH net v6 1/3] net: remove CAP_SYS_RAWIO zero-padding in dev_validate_header Qihang
2026-08-06 3:07 ` Willem de Bruijn
2026-08-05 12:57 ` [PATCH net v6 2/3] packet: use consistent hard_header_len in non-ring send paths Qihang
2026-08-05 12:57 ` [PATCH net v6 3/3] packet: use consistent hard_header_len in TX_RING send path Qihang
2026-08-06 16:50 ` [PATCH net v6 0/3] net: fix hard_header_len races in packet send paths patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-07-30 8:29 [PATCH net v5 0/2] packet: use consistent hard_header_len in " Qihang
2026-08-04 9:00 ` [PATCH net v6 0/3] net: fix hard_header_len races in packet " Qihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805125729.19220-1-q.h.hack.winter@gmail.com \
--to=q.h.hack.winter@gmail.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox