From: Jakub Kicinski <kuba@kernel.org>
To: Deep Shah <deepshah146@gmail.com>
Cc: netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next v3 0/2] ptp: reject frequency adjustments that overflow scaled_ppm_to_ppb()
Date: Wed, 5 Aug 2026 18:16:38 -0700 [thread overview]
Message-ID: <20260805181638.50b6cfcf@kernel.org> (raw)
In-Reply-To: <20260801222923.39017-1-deepshah146@gmail.com>
On Sat, 1 Aug 2026 22:29:21 +0000 Deep Shah wrote:
> - patch 2:
> - cast the test value to the type of tx.freq rather than guarding on
> __SIZEOF_LONG__, which skipped the assignment on x32 and other
> y2038 configurations and failed the test there (Simon Horman)
> - add the built binary to .gitignore
the test doesn't seem worth carrying in the tree TBH
If we really want this sort of unit test we should probably
integrate it with more with the net side (the PTP target doesn't get
run by netdev CI) and automatically create a netdevsim device which
has a SW PTP etc. Again, not sure it's worth for a trival overflow test
tho.
next prev parent reply other threads:[~2026-08-06 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 22:29 [PATCH net-next v3 0/2] ptp: reject frequency adjustments that overflow scaled_ppm_to_ppb() Deep Shah
2026-08-01 22:29 ` [PATCH net-next v3 1/2] " Deep Shah
2026-08-02 18:49 ` Richard Cochran
2026-08-01 22:29 ` [PATCH net-next v3 2/2] selftests: ptp: add a regression test for the frequency adjustment overflow Deep Shah
2026-08-02 18:49 ` Richard Cochran
2026-08-06 1:16 ` Jakub Kicinski [this message]
2026-08-06 1:20 ` [PATCH net-next v3 0/2] ptp: reject frequency adjustments that overflow scaled_ppm_to_ppb() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805181638.50b6cfcf@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=deepshah146@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shuah@kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox