From: Jakub Kicinski <kuba@kernel.org>
To: Dhanushkalyan G <Dhanushkalyan.G@microchip.com>
Cc: <netdev@vger.kernel.org>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
<UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Thangaraj Samynathan" <Thangaraj.S@microchip.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: lan743x: set interrupt moderation timer based on link speed
Date: Thu, 6 Aug 2026 12:14:47 -0700 [thread overview]
Message-ID: <20260806121447.3031bcb9@kernel.org> (raw)
In-Reply-To: <20260803124847.17315-2-Dhanushkalyan.G@microchip.com>
On Mon, 3 Aug 2026 18:18:46 +0530 Dhanushkalyan G wrote:
> Set the moderation timer as a function of the negotiated link speed in
> the MAC link-up path: 64 us at 2.5G, 150 us at 1G, and 330 us at
> 100M/10M. The interrupt-vector-to-timer mapping (INT_MOD_MAP) is static,
> so it stays programmed once at interrupt open; only the timer value
> (INT_MOD_CFG) is updated, from the new lan743x_config_int_mod() helper,
> when the link comes up.
This patch should go away. With patch 2 user can chose the right
coalescing settings for themselves. adaptive coalescing means that
the driver adjusts the coalescing settings based on _traffic_ not
link speed. Please don't (ab)use that for the trivial link speed based
heuristic. There's a library called DIM which implements the dynamic
algo which you can plug into your driver if you want (it even has docs)
next prev parent reply other threads:[~2026-08-06 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 12:48 [PATCH net-next 0/2] net: lan743x: speed-based and user-configurable interrupt moderation Dhanushkalyan G
2026-08-03 12:48 ` [PATCH net-next 1/2] net: lan743x: set interrupt moderation timer based on link speed Dhanushkalyan G
2026-08-06 19:14 ` Jakub Kicinski [this message]
2026-08-03 12:48 ` [PATCH net-next 2/2] net: lan743x: add ethtool interrupt coalescing support Dhanushkalyan G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806121447.3031bcb9@kernel.org \
--to=kuba@kernel.org \
--cc=Dhanushkalyan.G@microchip.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox