Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Tung Nguyen <tung.quang.nguyen@est.tech>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, jmaloy@redhat.com, horms@kernel.org,
	tipc-discussion@lists.sourceforge.net, Xiang Mei <xmei5@asu.edu>,
	Weiming Shi <bestswngs@gmail.com>
Subject: Re: [PATCH net v11] tipc: fix NULL deref in tipc_named_node_up() on empty publication list
Date: Thu, 6 Aug 2026 13:04:24 -0700	[thread overview]
Message-ID: <20260806130424.62a59734@kernel.org> (raw)
In-Reply-To: <20260805161356.193230-1-tung.quang.nguyen@est.tech>

On Wed,  5 Aug 2026 23:13:09 +0700 Tung Nguyen wrote:
> User-space applications can bind a large number of service addresses to
> one or more sockets. Each binding of a local-scope service address inserts
> one entry (publication) into the TIPC name table. If the number of these
> publications exceeds TIPC_MAX_PUBL (65535), protocol service types
> (such as node state and link state) are no longer inserted into the name
> table. This causes two issues:

make htmldoc on the testing branch flagged:

Documentation/networking/tipc:184: ./net/tipc/name_distr.c:261: ERROR: Unexpected indentation. [docutils]
Documentation/networking/tipc:184: ./net/tipc/name_distr.c:262: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]

+/**
+ * tipc_named_dist_cluster_scope - distribute all publications to specified node
+ * @net: the associated network namespace
+ * @dnode: destination node
+ *
+ * Return:
+ * 0 on success
+ * -EINVAL on failure, insert duplicate publication or reach the max number of
+ *  supported publications

is it this line ?

+ * -ENOBUFS on failure, no buffer space is available
+ */

  reply	other threads:[~2026-08-06 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 16:13 [PATCH net v11] tipc: fix NULL deref in tipc_named_node_up() on empty publication list Tung Nguyen
2026-08-06 20:04 ` Jakub Kicinski [this message]
2026-08-07  2:32   ` Tung Quang Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806130424.62a59734@kernel.org \
    --to=kuba@kernel.org \
    --cc=bestswngs@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jmaloy@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=tung.quang.nguyen@est.tech \
    --cc=xmei5@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox