From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10537442388 for ; Fri, 7 Aug 2026 13:13:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786108426; cv=none; b=ubXjGKd7eQj/erwXoxHLNz6MjPG8JNKwRQ5+WkifaOTrDQ1jTSNnslFgf68Gt8r1t4elCiUsF3VK+At+A/oaywgpOXpr8s12MbqSbwSTcM2fVr7rB6oE4kU849CV2vKlhui4zTjfQdgJKuEnnjlGO5z1xIutLwARkBw7QCT0FrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786108426; c=relaxed/simple; bh=aSuv9m3SRfbbDLL6UMHt2VSLxYYZd1xdbxrhJPEfNVg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ucn+oDWEuyOYH4tRMKr6+YPBqqGymN/tQbYmZIwV+h/8WCU7R56ynOSs2eNZXekpdUp/aYISIEcX2FVNZxIz1cmlsjfE02liMQOBDbqO7DnS42aJCtlqL/QL7H8VqRevw6ciBGuY1IHFhi+a1AcixRFzXfyqTqcNxMRi98ISQEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BP1ipZgX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BP1ipZgX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49545ba3d4eso18435705e9.3 for ; Fri, 07 Aug 2026 06:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786108410; x=1786713210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=DAXATgTkufRgDBElO/+VP5qlX2m9wHSj0la+spoaFT0=; b=BP1ipZgX2ufZt0nRDe/qJpc2neO9ZXvBxa6i6U3bu3TUfB5imRTiqm98b/xQl/0/Ox 7Jj7nHYisys5HWnnmv+dwZ5yhSsE+wvOVt4xYnHs14Iu1NQmajVRp8nM5mcgfzDJn2// +wQV0ZqGhcdGU+2ODVp/X/1zXBNAkxvFM29bSIdOLOJpHbSsfYf6bqsbrndnFhE1LGIc wUTtKkyyuAlTWfiguAyezX63OXrDBN9nOj+tEWHYt8fZwN0N1UiZVW9BZRth79ItyZVS 9sAbE/qfqBrRcw0okBXF9cIzyAVpasRaoHbDO2EBg4RORuHBwLeTIzjsbrHJRAojfqJN 8nmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786108410; x=1786713210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DAXATgTkufRgDBElO/+VP5qlX2m9wHSj0la+spoaFT0=; b=m8qKBsPbrrl1WixvjUTE3GX0upVOeYHQ47hFdqv9fBD4gTBgQ0TpWdTIqgo9XSNuv4 A5ubuxL1BbsPslVzCjkqRxV7/1WeVX0mrfzpMieoCj0BQiWLb4LbcVjZckLcWpo7wK9W Fdor/yoSABRMnE3TlS6JWhz59Rh/IFRi5+0yTJK7VZepy4Czxt5fNC+vIMBCm3bIq9js chtpI6FtxppV6G5yvBXlps1AnJWxeZHT4uY1HrBrA60ciN/fBM8xkyjNE3sQc8sjkAH+ QkLR7/5N264OSU9LS+9DxsOF7VOB+Olk/2jYOgfFCkaV+txLJnKN5y9nG52cNq+NuHYN ZnjA== X-Forwarded-Encrypted: i=1; AHgh+RoEheEkTKfGTy30sp30ckt4Fu0Bzv1Y2cP+jN6JKXRaE7mVGfsO09DxXEkSeSCdWbbMb6Q4d20=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7l6rmhbgdeJWYH/aM5zyIIqJevJjqsxzuIRHr0K9C+IyufqiO lwqVfU8CKJWK6aTu4DpM1h21m0hy9dO/ifERKTJKhenzw+vapCGDTSog X-Gm-Gg: AR+sD10ooGI/FjSOmmETHVcMGg/cTc0OBIgqys7573bpK81wPHhAy3I5/OnIuROTdq8 ZtYF62oPem4XUB1nxCSk10FOYarr8f2uc8zLhVBfSCmN0jLCzFo1qgAs+a9FIZSrH0BLM+eaTUX J7lhg7bCWGgfZVKEdHbi/gCX8rGCmS6xbvHDxHM7XUnd4vQWCWGFoOilDMRlp/mNH7fHWiMU1Ij jJOM8j40cmZrZX82y+Ib/G5OMm7t+si9uYYIoML9x3oGUuO24iNTN7+4OEdPZyfwbFrqgNEpQJ8 U5/YT3/Jg32sHsPGGCexmHq7pNIv7QR0pY2kAZcZkKozfahsJIZS+eTP/EfhSeWtUOF02RMNZGc 7jKEdWJrysWHi0tLdJQPad+w6NOn4gZTUxBCNka10MiJ0q5oeMicowET/CMCuKd38K4aORUXnBh b3Hn4qudDArWt/HmDvRvGAVHZPi9ffzh99nUcDcB8ErfK6xZbNGW+dZWeO/sASB6ky6se2c6YHJ 6yI2RA2Sj0OIMbQWAxK7qOtrdKhKg5Gh4KeSfsHQt+htDoFOl2zAA== X-Received: by 2002:a05:600c:19cd:b0:498:519:e660 with SMTP id 5b1f17b1804b1-4994e72f7b6mr296830145e9.4.1786108410336; Fri, 07 Aug 2026 06:13:30 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-87-19-255-168.retail.telecomitalia.it. [87.19.255.168]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4995c7b2b68sm58827665e9.4.2026.08.07.06.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 06:13:29 -0700 (PDT) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v11 09/12] net: phylink: add .pcs_link_down PCS OP Date: Fri, 7 Aug 2026 15:12:51 +0200 Message-ID: <20260807131301.192060-10-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807131301.192060-1-ansuelsmth@gmail.com> References: <20260807131301.192060-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Permit for PCS driver to define specific operation to tear down the link between the MAC and the PCS. This might be needed for some PCS that reset counter or require special reset to correctly work if the link needs to be restored later. On phylink_link_down() call, the additional phylink_pcs_link_down() will be called after .mac_link_down to tear down the link. PCS driver will need to define .pcs_link_down to make use of this. Signed-off-by: Christian Marangi Reviewed-by: Maxime Chevallier --- drivers/net/phy/phylink.c | 9 +++++++++ include/linux/phylink.h | 12 ++++++++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 69d4f6675db0..2e8d11573e3a 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -982,6 +982,12 @@ static void phylink_pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode, pcs->ops->pcs_link_up(pcs, neg_mode, interface, speed, duplex); } +static void phylink_pcs_link_down(struct phylink_pcs *pcs) +{ + if (pcs && pcs->ops->pcs_link_down) + pcs->ops->pcs_link_down(pcs); +} + static void phylink_pcs_disable_eee(struct phylink_pcs *pcs) { if (pcs && pcs->ops->pcs_disable_eee) @@ -1683,6 +1689,9 @@ static void phylink_link_down(struct phylink *pl) pl->mac_ops->mac_link_down(pl->config, pl->act_link_an_mode, pl->cur_interface); + + phylink_pcs_link_down(pl->pcs); + phylink_info(pl, "Link is Down\n"); } diff --git a/include/linux/phylink.h b/include/linux/phylink.h index ca9dfc142388..ea554c0d41f8 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -528,6 +528,7 @@ struct phylink_pcs { * @pcs_an_restart: restart 802.3z BaseX autonegotiation. * @pcs_link_up: program the PCS for the resolved link configuration * (where necessary). + * @pcs_link_down: tear down link between MAC and PCS. * @pcs_disable_eee: optional notification to PCS that EEE has been disabled * at the MAC. * @pcs_enable_eee: optional notification to PCS that EEE will be enabled at @@ -555,6 +556,7 @@ struct phylink_pcs_ops { void (*pcs_an_restart)(struct phylink_pcs *pcs); void (*pcs_link_up)(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, int speed, int duplex); + void (*pcs_link_down)(struct phylink_pcs *pcs); void (*pcs_disable_eee)(struct phylink_pcs *pcs); void (*pcs_enable_eee)(struct phylink_pcs *pcs); int (*pcs_pre_init)(struct phylink_pcs *pcs); @@ -690,6 +692,16 @@ void pcs_an_restart(struct phylink_pcs *pcs); void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, int speed, int duplex); +/** + * pcs_link_down() - tear down link between MAC and PCS + * @pcs: a pointer to a &struct phylink_pcs. + * + * This call will be made just after mac_link_down() to inform the PCS the + * link has gone down. PCS should be configured to stop processing packets + * for transmission and reception. + */ +void pcs_link_down(struct phylink_pcs *pcs); + /** * pcs_disable_eee() - Disable EEE at the PCS * @pcs: a pointer to a &struct phylink_pcs -- 2.53.0