Netdev List
 help / color / mirror / Atom feed
From: Jianhui Xu <neuromoments@gmail.com>
To: mail@birger-koblitz.de
Cc: andrew+netdev@lunn.ch, andrew@lunn.ch, davem@davemloft.net,
	edumazet@google.com, hkallweit1@gmail.com, kuba@kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux@armlinux.org.uk, netdev@vger.kernel.org,
	neuromoments@gmail.com, pabeni@redhat.com
Subject: Re: [PATCH net-next v6 02/13] ax88179_178a: Split driver into library and device specific code
Date: Sun,  9 Aug 2026 08:57:32 +0800	[thread overview]
Message-ID: <20260809005732.3084198-1-neuromoments@gmail.com> (raw)
In-Reply-To: <20260806-ax88179a-v6-2-fde7414619e6@birger-koblitz.de>

Hi Birger,

I noticed what looks like a typo in the newly added `ax88179_read_cmd()`:

```c
if (size == 2) {
	u16 buf = 0;

	ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf);
	le16_to_cpus(&buf);
	*((u16 *)data) = buf;
} else if (size == 2) {
	u32 buf = 0;

	ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf);
	le32_to_cpus(&buf);
	*((u32 *)data) = buf;
}
```

The second condition should presumably be:

```c
} else if (size == 4) {
```

The original implementation before this code was moved to `ax88179_lib.c`
also used `else if (4 == size)`.

As written, the `u32` branch is unreachable, so 4-byte reads fall through
to `__ax88179_read_cmd()` without the `le32_to_cpus()` conversion.

Regards,
Jianhui

  reply	other threads:[~2026-08-09  0:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 19:35 [PATCH net-next v6 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-08-06 19:35 ` [PATCH net-next v6 01/13] ax88179_178a: Fix endianness of pause watermark register Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 02/13] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-08-09  0:57   ` Jianhui Xu [this message]
2026-08-09  3:39     ` Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 03/13] ax88179_178a: Add netdev2data() convenience function Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 04/13] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 07/13] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 10/13] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 11/13] ax88179_178a: Update driver name and information Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-08-06 19:36 ` [PATCH net-next v6 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
2026-08-09  1:36 ` [PATCH net-next v6 00/13] ax88179_178a: Add support for AX88179A-based chips Jianhui Xu
2026-08-09  4:33   ` Birger Koblitz
2026-08-10  1:35     ` Jianhui Xu
2026-08-10 10:43       ` Birger Koblitz
2026-08-10 13:25         ` Andrew Lunn
2026-08-10 16:17           ` Birger Koblitz
2026-08-10 17:35             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260809005732.3084198-1-neuromoments@gmail.com \
    --to=neuromoments@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mail@birger-koblitz.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox