Netdev List
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Yuyang Huang <sigefriedhyy@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Chris J Arges <carges@cloudflare.com>,
	Daniel Zahka <daniel.zahka@gmail.com>,
	David Ahern <dsahern@kernel.org>, David Wei <dw@davidwei.uk>,
	Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Willem de Bruijn <willemb@google.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v6 01/10] ipv6: add ip6_del_rt_reason()
Date: Sun, 9 Aug 2026 11:50:43 +0300	[thread overview]
Message-ID: <20260809085043.GA2339479@shredder> (raw)
In-Reply-To: <20260808005642.26901-2-sigefriedhyy@gmail.com>

On Sat, Aug 08, 2026 at 09:56:33AM +0900, Yuyang Huang wrote:
> Add RTA_DEL_REASON and enum rt_del_reason to the rtnetlink uAPI, and
> add ip6_del_rt_reason(), which takes the reason a route is being
> deleted. It has no skip_notify argument: a caller that records a
> deletion reason wants the notification that carries it.
> 
> The reason is unused for now. Subsequent patches propagate it to the
> deletion path and report it on RTM_DELROUTE.
> 
> Signed-off-by: Yuyang Huang <sigefriedhyy@gmail.com>

"
Discovered by: opus-5, old-prompts · Missed by: sashiko-gemini
Is the statement "the kernel rejects it in requests" accurate for the whole
shared RTA_* namespace?
"

Nitpick. It's accurate for IPv6 which is the only address family that
currently emits the new attribute. It's also accurate for IPv4. Other
address families (MPLS / PHONET / IPMR) can start making use of
strict_start_type in their policies, but it doesn't belong in this
series.

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

  reply	other threads:[~2026-08-09  8:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08  0:56 [PATCH net-next v6 00/10] ipv6: report why a route was deleted in RTM_DELROUTE Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 01/10] ipv6: add ip6_del_rt_reason() Yuyang Huang
2026-08-09  8:50   ` Ido Schimmel [this message]
2026-08-09 12:30     ` Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 02/10] ipv6: propagate the route deletion reason to fib6_del_route() Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 03/10] ipv6: record the reason for kernel-initiated route deletions Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 04/10] ipv6: add a deletion reason argument to rt6_fill_node() Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 05/10] ipv6: expose the route deletion reason in RTM_DELROUTE Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 06/10] ipv6: add inet6_rt_del_notify() Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 07/10] netlink: specs: rt-route: add route notifications Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 08/10] netlink: specs: rt-route: split out the request attribute list Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 09/10] netlink: specs: rt-route: add the route deletion reason Yuyang Huang
2026-08-08  0:56 ` [PATCH net-next v6 10/10] selftests: net: verify RTA_DEL_REASON on route deletion Yuyang Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260809085043.GA2339479@shredder \
    --to=idosch@nvidia.com \
    --cc=carges@cloudflare.com \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dimitri.daskalakis1@gmail.com \
    --cc=donald.hunter@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=sigefriedhyy@gmail.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox