From: Pengfei Zhang <zhangfeionline@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
zhangpengfei16@xiaomi.com
Subject: Re: [PATCH net-next] net: ethernet: drop skbs with a short linear part in eth_type_trans()
Date: Mon, 10 Aug 2026 15:59:35 +0800 [thread overview]
Message-ID: <20260810075935.2961699-1-zhangfeionline@gmail.com> (raw)
In-Reply-To: <CANn89iKByRiWyVdPCzvb5+0WWrPcaeLSXDqP6GqUHbqRwMF9bA@mail.gmail.com>
On Fri, Aug 7, 2026 at 6:52 PM Eric Dumazet <edumazet@google.com> wrote:
> This is obviously a wrong patch. Please fix faulty drivers instead of
> adding more code in our fast path.
>
> If you use header split, you are supposed to use modern NAPI api, like
> napi_gro_frags() which will take care of that.
Thanks for the review.
I put the test in eth_type_trans() because I thought the stack should not
be brought down by a driver handing it a malformed skb. I take your point
about the cost on the fast path, and that napi_gro_frags() already takes
care of this.
I will drop the patch. I do not have amd-xgbe or dwc-xlgmac hardware, so
I will not send an untested driver change; if I can get access to a device
that behaves this way, I will fix and verify the driver there.
Thanks,
Pengfei
next prev parent reply other threads:[~2026-08-10 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 10:28 [PATCH net-next] net: ethernet: drop skbs with a short linear part in eth_type_trans() Pengfei Zhang
2026-08-07 10:52 ` Eric Dumazet
2026-08-10 7:59 ` Pengfei Zhang [this message]
2026-08-10 8:10 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810075935.2961699-1-zhangfeionline@gmail.com \
--to=zhangfeionline@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangpengfei16@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox