From: Jakub Kicinski <kuba@kernel.org>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: calxeda: xgmac: Fix use-after-free in xgmac_remove due to race condition
Date: Mon, 10 Aug 2026 14:43:59 -0700 [thread overview]
Message-ID: <20260810144359.6e609a22@kernel.org> (raw)
In-Reply-To: <e556148b7a938f83f8470bb3bde5b856eb9ba271.1785809990.git.xiaopei01@kylinos.cn>
On Tue, 4 Aug 2026 10:21:26 +0800 Pei Xiao wrote:
> In xgmac_probe, &priv->tx_timeout_work is bound with
> xgmac_tx_timeout_work, and xgmac_interrupt and xgmac_tx_timeout can
> both schedule this work on system_wq.
AI reviewer reports that this can add a deadlock.
Looks like we're trading one bug for another.
If you don't have access to this HW or ability to test your patches
in general - please don't try to send such superficial fixes.
--
pw-bot: reject
next prev parent reply other threads:[~2026-08-10 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 2:21 [PATCH] net: calxeda: xgmac: Fix use-after-free in xgmac_remove due to race condition Pei Xiao
2026-08-10 21:43 ` Jakub Kicinski [this message]
2026-08-11 1:33 ` Pei Xiao
2026-08-11 14:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810144359.6e609a22@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox