From: Jakub Kicinski <kuba@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Tim Bird <tim.bird@sony.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4] keys, dns: Drop unused NUL terminator from upayload->data
Date: Mon, 10 Aug 2026 16:22:32 -0700 [thread overview]
Message-ID: <20260810162232.3eb7e73a@kernel.org> (raw)
In-Reply-To: <20260806200454.245444-3-thorsten.blum@linux.dev>
On Thu, 6 Aug 2026 22:04:54 +0200 Thorsten Blum wrote:
> upayload->data includes an extra NUL terminator even though it is never
> used as a C string. In-tree users access only the first
> upayload->datalen bytes.
>
> Remove the redundant NUL terminator and allocate one byte less for
> upayload->data in dns_resolver_preparse().
Okay. You know how I feel about this change already. I'll apply but
please adjust your filter for changes which are worth maintainer's time
next prev parent reply other threads:[~2026-08-10 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 20:04 [PATCH net-next v4] keys, dns: Drop unused NUL terminator from upayload->data Thorsten Blum
2026-08-10 10:04 ` Simon Horman
2026-08-10 23:22 ` Jakub Kicinski [this message]
2026-08-10 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810162232.3eb7e73a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@linux.dev \
--cc=tim.bird@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox