From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7131E42AFB1 for ; Tue, 11 Aug 2026 09:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786440556; cv=none; b=OoB5AQVyWCbZXTXvIA7qAxtHFk6QJpaAW01MctqkN5ax9qvUYidqr4KkjYwUxxG7+l11IsJGj0JMdT22gU+WiS0P2FdINbFO8sLMb/AVMIyoXsFXXzOUMxDyTCPP/UZWCsG0tikOg+tHLu1EEHXf2jWPFVTjvBpgRSHN4UjQhv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786440556; c=relaxed/simple; bh=QtqM9aD3Rc1BEIaUbReSZtmrvLYan2wKqSCw6jE7e8k=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iW0R44Zy1noLNvXz8TaTfHfVJzOXgMFiURWTPQMe+HpJNxVOQwvu0XzV67eG1Lq6vzSapF0j0HIUVgRulnVheB/nesi7aDVi9miJlpm8Fd3hmTHquWE0zy+DaoFTzY/XbRunAKL6/9tHQekC8SfiStdySu8uW4HQlSvrm25cW3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HtJJeLyB; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HtJJeLyB" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-495590dde14so8393025e9.0 for ; Tue, 11 Aug 2026 02:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786440551; x=1787045351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=BKPU7MMEAIUqK6hcn9eZIWf6Bc1O0LaW7zcFVojtXsw=; b=HtJJeLyBbSICYNkTqyFrD83kcV3Kl6Q+kMPzSFe3lllFGmM5mG1ctu2o+ritl551q2 9acazDxBJJ+d6cpi2XMTH2mHnZWLW00ClkQ9SkIot0uYOUVYI8EvyIbZ0eVxC3s1OUjZ iTrUMfDEHrtDlae0mFPGYzFVaY+pMo0MC57sr03VlfJ/iY9fXR9Ycc0cUljAPSS67fyN lZakecIt2YSTfV7oaEdkDS/MZryqmNaYGOgxdASYra/z4rbStF1bix6l4gJcQfxqasYE Cdzhuzk7dpJNcpQ25GXwnYIxGQ7DQ2bs0XMxmkCONSqU8G+Ib/kgmaMCPjdGlIa6Yhg6 bznw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786440551; x=1787045351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=BKPU7MMEAIUqK6hcn9eZIWf6Bc1O0LaW7zcFVojtXsw=; b=VuRyLrFYnWkCJqbk/t5Jilv9vagxoOwdczlWpZidB/3BDJwuT0O8Bxj/ItnVEdBG9U nJ26ldSpQrTerZH3fX1klHcm4TF91QDw9m7L9tWZUUQlg1rc4RX3jyGhojXr48CBTlRE tDdp9Lak4WkjTnCW27qYFtuj7KEDCyvINNmfjU8fZuGLeUhiranFAVyTLakc92oTVlKz sXKuz4oKkOam8QR9In/cpU5Gtt8ds4TeaWZ61fPyNSzEj3xxiI8G+GAbNR+xKaL9eVPM hFCAYUcuRFNKOe2PyQFROjmrL2NLvSANNk4CCPk4ZIYQDWAXUJZBlbSQHVeqIGFVA4UD CN0A== X-Forwarded-Encrypted: i=1; AHgh+RqKiUqhky0fD2UiO0+SBkZOVFnb3g9PBie6sD0+vPFrXY6ZYxZBcKI2OzhxGmgleyMJch8D0kw=@vger.kernel.org X-Gm-Message-State: AOJu0YwpnSwb56WaQM1kCpkxzi2nrgim6t6mbcUpWCQhOYooIMlXUf4n 0Q/cm301hJTyrC8eb064G5tvRFciZ27+b3qTAKDSVcRL8HbaDtVoeqhP X-Gm-Gg: AR+sD13elfccQP6DraWvuzvAyUJG9aYWvaO5E3s9NZgpUz4ul8dr5HQUbzXq/zDbHhN 8iCUO79Ppa65Pg7Se+h+cOIU2MhHAwaILU6JHpef0mqCBIIVI3Fl/v8mVLfdXY1dC8CjcbAvjQs xgOynIjGAoNkbN/wQNkurov10TaxPRCNlfN+1bPPmHu3fHvWlGyrO2A0k5VtjwsScdpm6H4jHFT 5yqh8+mUIJpTU3dfayN7YrFCQu6OCYwU2pNTvBCUwA0dANXzBZFk3lfFLDYOnrpcn90wJXxwyLy 0rowmEWfQ8ZTG6z2KYQtQIRH1YJxUnY36a/R65LwvfLr6ECJL6XtnYf1PtZAzJ/Tut2iV/qltzO /9MWBEQOZBzzuQ9VBuqHRehmuXlTap6fFVIkqxrThqbQm6FgEmWJ+ExXObLz/QXe06MSELOtlE7 zYj4k7rgws5mRReLzSHyFJA69JfE9eafkeIicje1+CnXYgkAxWSu6jgNADPSCbtI2OOYFW4Fl0n hwsgKho16x1/tAniF63/RNA/DqIpC+LoEUALbK9Ey++pgUO/gtHxg0skCg= X-Received: by 2002:a05:600c:8904:b0:498:519:e660 with SMTP id 5b1f17b1804b1-49978431e56mr28291035e9.4.1786440550379; Tue, 11 Aug 2026 02:29:10 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-87-20-3-207.retail.telecomitalia.it. [87.20.3.207]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4997402a89bsm56135735e9.0.2026.08.11.02.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:29:09 -0700 (PDT) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v13 05/12] net: phylink: support PCS provider release Date: Tue, 11 Aug 2026 11:28:30 +0200 Message-ID: <20260811092843.673837-6-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260811092843.673837-1-ansuelsmth@gmail.com> References: <20260811092843.673837-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for release of fwnode PCS from a PCS provider. This works by creating a global notifier for the PCS provider and making each phylink instance that makes use of fwnode subscribe to this notifier. The PCS notifier will emit the event FWNODE_PCS_PROVIDER_DEL every time a new PCS provider is released. phylink will then react to this event and will call the new function fwnode_pcs_matches_provider() on each PCS of the phylink instance and will check if the PCS is provided by the PCS provider that is getting released. If a related PCS is found, then such PCS is removed from the phylink instance PCS list and the supported_interfaces value is updated. The flag force_major_config is set to make phylink resolve reconfigure the interface (even if it didn't change). This is needed to handle the special case when the current PCS used by phylink is removed and a major_config is needed to propagae the configuration change. With this option enabled we also force mac_config even if the PHY link is not up for the in-band case. Finally a phylink resolve is triggered to handle the PCS removal. Protect every access of phylink pcs_list with state_mutex to handle async PCS provider release. Signed-off-by: Christian Marangi --- drivers/net/pcs/pcs.c | 47 +++++++++++++ drivers/net/phy/phylink.c | 141 ++++++++++++++++++++++++++++++++++++-- include/linux/pcs/pcs.h | 69 +++++++++++++++++++ 3 files changed, 250 insertions(+), 7 deletions(-) diff --git a/drivers/net/pcs/pcs.c b/drivers/net/pcs/pcs.c index 39550d9a12a2..25b3248e8b93 100644 --- a/drivers/net/pcs/pcs.c +++ b/drivers/net/pcs/pcs.c @@ -22,6 +22,19 @@ struct fwnode_pcs_provider { static LIST_HEAD(fwnode_pcs_providers); static DEFINE_MUTEX(fwnode_pcs_mutex); +static BLOCKING_NOTIFIER_HEAD(fwnode_pcs_notify_list); + +int register_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&fwnode_pcs_notify_list, nb); +} +EXPORT_SYMBOL_GPL(register_fwnode_pcs_notifier); + +int unregister_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_unregister(&fwnode_pcs_notify_list, nb); +} +EXPORT_SYMBOL_GPL(unregister_fwnode_pcs_notifier); struct phylink_pcs *fwnode_pcs_simple_xlate(struct fwnode_reference_args *pcsspec, void *data) @@ -74,6 +87,11 @@ void fwnode_pcs_del_provider(struct fwnode_pcs_provider *pp) mutex_unlock(&fwnode_pcs_mutex); + /* Signal phylink to release any PCS from this provider */ + blocking_notifier_call_chain(&fwnode_pcs_notify_list, + FWNODE_PCS_PROVIDER_DEL, + pp); + fwnode_handle_put(pp->fwnode); kfree(pp); } @@ -183,6 +201,35 @@ struct phylink_pcs *fwnode_pcs_get(const struct fwnode_handle *fwnode, unsigned } EXPORT_SYMBOL_GPL(fwnode_pcs_get); +bool fwnode_pcs_matches_provider(struct fwnode_pcs_provider *provider, + const struct fwnode_handle *fwnode, + struct phylink_pcs *pl_pcs) +{ + struct fwnode_reference_args pcsspec; + int index = 0; + int ret; + + while (true) { + struct phylink_pcs *pcs; + + ret = fwnode_parse_pcsspec(fwnode, index, NULL, &pcsspec); + if (ret) + return false; + + pcs = __fwnode_pcs_get_from_pcsspec_provider(&pcsspec, provider); + if (!IS_ERR(pcs) && pcs == pl_pcs) { + fwnode_handle_put(pcsspec.fwnode); + return true; + } + + fwnode_handle_put(pcsspec.fwnode); + index++; + } + + return false; +} +EXPORT_SYMBOL_GPL(fwnode_pcs_matches_provider); + unsigned int fwnode_phylink_pcs_count(struct fwnode_handle *fwnode) { struct fwnode_reference_args out_args; diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index b9a5cd123775..dbf0e8292f7b 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -63,6 +64,7 @@ struct phylink { /* List of available PCS */ struct list_head pcs_list; + struct notifier_block fwnode_pcs_nb; /* What interface are supported by the current link. * Can change on removal or addition of new PCS. @@ -546,11 +548,15 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, bool pcs_found = false; int ret; + mutex_lock(&pl->state_mutex); + /* Get the PCS for this interface mode */ if (pl->mac_ops->mac_select_pcs) { pcs = pl->mac_ops->mac_select_pcs(pl->config, state->interface); - if (IS_ERR(pcs)) + if (IS_ERR(pcs)) { + mutex_unlock(&pl->state_mutex); return PTR_ERR(pcs); + } pcs_found = !!pcs; /* @@ -574,6 +580,7 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, * error and backtrace rather than oopsing the kernel. */ if (!pcs->ops) { + mutex_unlock(&pl->state_mutex); phylink_err(pl, "interface %s: uninitialised PCS\n", phy_modes(state->interface)); dump_stack(); @@ -583,6 +590,7 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, /* Recheck PCS to handle legacy way for .mac_select_pcs */ ret = phylink_validate_pcs_interface(pcs, state->interface); if (ret) { + mutex_unlock(&pl->state_mutex); phylink_err(pl, "selected PCS does not support %s\n", phy_modes(state->interface)); return -EINVAL; @@ -591,8 +599,10 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, /* Validate the link parameters with the PCS */ if (pcs->ops->pcs_validate) { ret = pcs->ops->pcs_validate(pcs, supported, state); - if (ret < 0 || phylink_is_empty_linkmode(supported)) + if (ret < 0 || phylink_is_empty_linkmode(supported)) { + mutex_unlock(&pl->state_mutex); return -EINVAL; + } /* Ensure the advertising mask is a subset of the * supported mask. @@ -602,6 +612,8 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, } } + mutex_unlock(&pl->state_mutex); + /* Then validate the link parameters with the MAC */ if (pl->mac_ops->mac_get_caps) capabilities = pl->mac_ops->mac_get_caps(pl->config, @@ -998,6 +1010,9 @@ static unsigned int phylink_inband_caps(struct phylink *pl, { struct phylink_pcs *pcs; bool pcs_found = false; + int ret = 0; + + mutex_lock(&pl->state_mutex); if (pl->mac_ops->mac_select_pcs) { pcs = pl->mac_ops->mac_select_pcs(pl->config, @@ -1013,9 +1028,14 @@ static unsigned int phylink_inband_caps(struct phylink *pl, } if (!pcs_found) - return 0; + goto exit; + + ret = phylink_pcs_inband_caps(pcs, interface); + +exit: + mutex_unlock(&pl->state_mutex); - return phylink_pcs_inband_caps(pcs, interface); + return ret; } static void phylink_pcs_poll_stop(struct phylink *pl) @@ -1555,7 +1575,9 @@ static void phylink_mac_initial_config(struct phylink *pl, bool force_restart) phylink_apply_manual_flow(pl, &link_state); if (phy) mutex_lock(&phy->lock); + mutex_lock(&pl->state_mutex); phylink_major_config(pl, force_restart, &link_state); + mutex_unlock(&pl->state_mutex); if (phy) mutex_unlock(&phy->lock); } @@ -1923,6 +1945,9 @@ static int phylink_fill_available_pcs(struct phylink *pl, if (!pcss) return -ENOMEM; + /* Lock state_mutex while filling to handle PCS notify */ + mutex_lock(&pl->state_mutex); + ret = config->fill_available_pcs(config, pcss, config->num_possible_pcs); if (ret < 0) goto out; @@ -1936,12 +1961,90 @@ static int phylink_fill_available_pcs(struct phylink *pl, list_add_tail(&pcs->list, &pl->pcs_list); } + mutex_unlock(&pl->state_mutex); + out: kfree(pcss); return ret; } +static void phylink_del_pcs(struct phylink *pl, struct phylink_pcs *pcs) +{ + lockdep_assert_held(&pl->state_mutex); + + list_del(&pcs->list); + pcs->phylink = NULL; + + /* + * Check if we are removing the PCS currently + * in use by this phylink instance. If this is the case, + * tear down the link, force phylink resolve to reconfigure the + * interface mode, disable the current PCS and set the + * phylink PCS to NULL. + */ + if (pl->pcs == pcs) { + if (pl->old_link_state) { + phylink_link_down(pl); + pl->old_link_state = false; + } + if (pl->cfg_link_an_mode == MLO_AN_INBAND) + timer_delete_sync(&pl->link_poll); + phylink_pcs_disable(pl->pcs); + + pl->force_major_config = true; + WRITE_ONCE(pl->pcs, NULL); + } +} + +static int pcs_provider_notify(struct notifier_block *self, + unsigned long val, void *data) +{ + struct phylink *pl = container_of(self, struct phylink, fwnode_pcs_nb); + struct fwnode_pcs_provider *pp = data; + struct phylink_pcs *pcs, *tmp; + bool resolve = false; + + rtnl_lock(); + + mutex_lock(&pl->state_mutex); + + /* + * Loop all the PCS for phylink instance and check if + * this notification is relevant for some of them. + */ + list_for_each_entry_safe(pcs, tmp, &pl->pcs_list, list) { + if (!fwnode_pcs_matches_provider(pp, pl->fwnode, pcs)) + continue; + + phylink_del_pcs(pl, pcs); + resolve = true; + } + + /* Exit early if nothing has changed */ + if (!resolve) { + mutex_unlock(&pl->state_mutex); + rtnl_unlock(); + return NOTIFY_DONE; + } + + /* Refresh supported interfaces */ + phy_interface_copy(pl->supported_interfaces, + pl->config->supported_interfaces); + list_for_each_entry(pcs, &pl->pcs_list, list) + phy_interface_or(pl->supported_interfaces, + pl->supported_interfaces, + pcs->supported_interfaces); + + mutex_unlock(&pl->state_mutex); + + rtnl_unlock(); + + phylink_run_resolve(pl); + + return NOTIFY_OK; +} + /** * phylink_create() - create a phylink instance * @config: a pointer to the target &struct phylink_config @@ -2005,10 +2108,18 @@ struct phylink *phylink_create(struct phylink_config *config, goto free_pl; } + /* First register notifier for hotplug PCS events */ + if (!phy_interface_empty(config->pcs_interfaces)) { + pl->fwnode_pcs_nb.notifier_call = pcs_provider_notify; + register_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + } + /* Fill the PCS list with available PCS from phylink config */ ret = phylink_fill_available_pcs(pl, config); if (ret < 0) - goto free_pl; + goto unregister_pcs_notify; + + mutex_lock(&pl->state_mutex); /* Link available PCS to phylink */ list_for_each_entry(pcs, &pl->pcs_list, list) @@ -2023,6 +2134,8 @@ struct phylink *phylink_create(struct phylink_config *config, pl->supported_interfaces, pcs->supported_interfaces); + mutex_unlock(&pl->state_mutex); + pl->mac_supports_eee_ops = phylink_mac_implements_lpi(mac_ops); pl->mac_supports_eee = pl->mac_supports_eee_ops && pl->config->lpi_capabilities && @@ -2054,7 +2167,7 @@ struct phylink *phylink_create(struct phylink_config *config, ret = phylink_parse_mode(pl, fwnode); if (ret < 0) - goto unlink_pcs_list; + goto unregister_pcs_notify; if (pl->cfg_link_an_mode == MLO_AN_FIXED) { ret = phylink_parse_fixedlink(pl, fwnode); @@ -2073,11 +2186,17 @@ struct phylink *phylink_create(struct phylink_config *config, release_link_gpio: if (pl->link_gpio) gpiod_put(pl->link_gpio); -unlink_pcs_list: +unregister_pcs_notify: + if (pl->fwnode_pcs_nb.notifier_call) + unregister_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + /* PCS notifier might queue a resolve, cancel it */ + cancel_work_sync(&pl->resolve); + mutex_lock(&pl->state_mutex); list_for_each_entry_safe(pcs, tmp, &pl->pcs_list, list) { list_del(&pcs->list); pcs->phylink = NULL; } + mutex_unlock(&pl->state_mutex); free_pl: fwnode_handle_put(pl->fwnode); kfree(pl); @@ -2102,14 +2221,22 @@ void phylink_destroy(struct phylink *pl) if (pl->link_gpio) gpiod_put(pl->link_gpio); + /* Unregister notifier for late PCS attach */ + if (pl->fwnode_pcs_nb.notifier_call) + unregister_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + cancel_work_sync(&pl->resolve); + mutex_lock(&pl->state_mutex); + /* Remove every PCS from phylink PCS list */ list_for_each_entry_safe(pcs, tmp, &pl->pcs_list, list) { pcs->phylink = NULL; list_del(&pcs->list); } + mutex_unlock(&pl->state_mutex); + fwnode_handle_put(pl->fwnode); kfree(pl); diff --git a/include/linux/pcs/pcs.h b/include/linux/pcs/pcs.h index ef2134c578c7..83e0a2ad4b09 100644 --- a/include/linux/pcs/pcs.h +++ b/include/linux/pcs/pcs.h @@ -4,7 +4,38 @@ #include +enum fwnode_pcs_notify_event { + FWNODE_PCS_PROVIDER_DEL, +}; + +struct fwnode_pcs_provider; + #if IS_ENABLED(CONFIG_FWNODE_PCS) +/** + * register_fwnode_pcs_notifier - Register a notifier block for fwnode + * PCS events + * @nb: pointer to the notifier block + * + * Registers a notifier block to the fwnode_pcs_notify_list blocking + * notifier chain. This allows phylink instance to subscribe for + * PCS provider events. + * + * Returns: 0 or a negative error. + */ +int register_fwnode_pcs_notifier(struct notifier_block *nb); + +/** + * unregister_fwnode_pcs_notifier - Unregister a notifier block for fwnode + * PCS events + * @nb: pointer to the notifier block + * + * Unregisters a notifier block to the fwnode_pcs_notify_list blocking + * notifier chain. + * + * Returns: 0 or a negative error. + */ +int unregister_fwnode_pcs_notifier(struct notifier_block *nb); + /** * fwnode_pcs_get - Retrieves a PCS from a firmware node * @fwnode: firmware node @@ -19,6 +50,27 @@ struct phylink_pcs *fwnode_pcs_get(const struct fwnode_handle *fwnode, unsigned int index); +/** + * fwnode_pcs_matches_provider() - Check whether a PCS belongs to a provider + * @provider: PCS provider to check + * @fwnode: firmware node containing the PCS references + * @pl_pcs: PCS to check + * + * Parse the PCS references from the "pcs-handle" property of a firmware node + * and use provider to determine whether pl_pcs is one of the PCS provided by + * provider. + * + * This function is intended to be used when handling provider removal + * notifications, where the provider is already known and its PCS need to be + * identified among the PCS associated with a phylink instance. + * + * Returns: true if pl_pcs is provided by provider and referenced by fwnode, + * false otherwise. + */ +bool fwnode_pcs_matches_provider(struct fwnode_pcs_provider *provider, + const struct fwnode_handle *fwnode, + struct phylink_pcs *pl_pcs); + /** * fwnode_phylink_pcs_count - Count PCS entries described in firmware node * @fwnode: firmware node @@ -52,12 +104,29 @@ int fwnode_phylink_pcs_parse(struct fwnode_handle *fwnode, struct phylink_pcs **available_pcs, unsigned int num_pcs); #else +static inline int register_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return -EOPNOTSUPP; +} + +static inline int unregister_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return -EOPNOTSUPP; +} + static inline struct phylink_pcs *fwnode_pcs_get(const struct fwnode_handle *fwnode, unsigned int index) { return ERR_PTR(-ENOENT); } +static inline bool fwnode_pcs_matches_provider(struct fwnode_pcs_provider *provider, + const struct fwnode_handle *fwnode, + struct phylink_pcs *pl_pcs) +{ + return false; +} + static inline unsigned int fwnode_phylink_pcs_count(struct fwnode_handle *fwnode) { return 0; -- 2.53.0