From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: dave.hansen@linux.intel.com, Liam.Howlett@oracle.com,
ljs@kernel.org, david@redhat.com, willy@infradead.org,
shakeel.butt@linux.dev, vbabka@kernel.org, jannh@google.com,
aliceryhl@google.com, arve@android.com, cmllamas@google.com,
christian@brauner.io, tkjos@android.com, dsahern@kernel.org,
davem@davemloft.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
netdev@vger.kernel.org, surenb@google.com
Subject: [PATCH v5 0/5] mm: Unconditional per-VMA locks and cleanups
Date: Tue, 11 Aug 2026 18:10:50 -0700 [thread overview]
Message-ID: <20260812011056.902771-1-surenb@google.com> (raw)
v2 version of this patchset [1] was written by Dave Hansen and per his
request, I'm taking over this series.
tl;dr: Make per-VMA locks available in all configs. Simplify some
of the per-VMA lock users now that they can rely on them being
always available.
Binder and networking folks: Your code is the target of the cleanups.
I'm cc'ing you now on v2 because there's emerging consensus on the mm
side that the approach here is sane. I'm not quite sure how this pile
would get merged, but ack/review tags would be appreciated if this
looks good to you.
Longer version:
When working on some x86 shadow stack code, it was a real pain to
avoid causing recursive locking problems with mmap_lock. One way
to avoid those was to avoid mmap_lock and use per-VMA locks instead.
They are great, but they are not available in all configs which
makes them unusable in generic code, or if you want to completely
avoid mmap_lock.
Make per-VMA locks available in all configs. Right now, they are
only available on select architectures when SMP and MMU are enabled.
But all of the primitives that per-VMA locks are built on (RCU, maple
trees, refcounts) work just fine without SMP or MMU.
The only real downside is that making VMAs a wee bit bigger on !MMU
and !SMP builds.
The upside is much cleaner code, lower complexity and less #ifdeffery.
Clean up a binder VMA locking site now that it can rely on per-VMA
locks.
Building on top of universally-available per-VMA locks, introduce a
new helper. Since the new API does not require callers to have a
fallback to mmap_lock, it's much easier to use. Callers can
potentially replace this very common kernel idiom:
mmap_read_lock(mm);
vma = vma_lookup()
// fiddle with vma
mmap_read_unlock(mm);
with:
vma = vma_start_read_unlocked(mm, address);
// fiddle with vma
vma_end_read(vma);
Which avoids mmap_lock entirely in the fast path.
Use that new API for another binder site and one in the TCP code.
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: Jann Horn <jannh@google.com>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Cc: linux-mm@kvack.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Todd Kjos <tkjos@android.com>
Cc: Christian Brauner <christian@brauner.io>
Cc: Carlos Llamas <cmllamas@google.com>
Cc: Alice Ryhl <aliceryhl@google.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org
Changes from v4 [2]:
Patch 1:
- Changed vma_assert_locked() NOMMU implementation to assert ma->vm_mm is
locked, per Sashiko
- Amended patch 1 changelog to include vma_start_read_locked() and
lock_vma_under_rcu in NOMMU considerations section, per Lorenzo Stoakes
- Changed comments for stack_map_lock_vma(), per Matthew Wilcox
- Added early exit in lock_vma_under_rcu() for !CONFIG_MMU,
per Lorenzo Stoakes
Patch 2:
- Updated changelog to explain the extra change making missing VMA
handling consistent, per Carlos Llamas
Patch 3:
- Rewrote changelog to better represent the changes in the patch,
per Matthew Wilcox
Patch 5:
- Fixed vma_start_read_unlocked() function name in the changelog,
per Matthew Wilcox
All patches
- Added Acked-by and Reviewed-by, per Vlastimil Babka, Lorenzo Stoakes and
Alice Ryhl
- Rebased over mm-unstable, per Lorenzo Stoakes
Applies cleanly over mm-unstable
[1] https://lore.kernel.org/all/20260610230409.A44D29FA@davehans-spike.ostc.intel.com/
[2] https://lore.kernel.org/all/20260806200548.3124802-1-surenb@google.com/
Dave Hansen (5):
mm: Make per-VMA locks available universally
binder: Make shrinker rely solely on per-VMA lock
mm: Add RCU-based VMA lookup helper that waits for writers
binder: Remove mmap_lock fallback
tcp: Remove mmap_lock fallback path
arch/arm/Kconfig | 1 -
arch/arm64/Kconfig | 1 -
arch/loongarch/Kconfig | 1 -
arch/powerpc/platforms/powernv/Kconfig | 1 -
arch/powerpc/platforms/pseries/Kconfig | 1 -
arch/riscv/Kconfig | 1 -
arch/s390/Kconfig | 1 -
arch/x86/Kconfig | 2 -
drivers/android/binder/page_range.rs | 19 +-----
drivers/android/binder_alloc.c | 62 +++++++----------
fs/proc/internal.h | 2 -
fs/proc/task_mmu.c | 93 -------------------------
include/linux/mm.h | 12 ----
include/linux/mm_types.h | 8 +--
include/linux/mmap_lock.h | 94 +++++++++++---------------
kernel/bpf/stackmap.c | 17 ++---
kernel/bpf/task_iter.c | 2 +-
kernel/fork.c | 2 -
mm/Kconfig | 12 ----
mm/Kconfig.debug | 1 -
mm/debug.c | 4 --
mm/init-mm.c | 2 -
mm/memory.c | 2 -
mm/mmap_lock.c | 61 ++++++++++-------
mm/pagewalk.c | 2 -
mm/rmap.c | 2 -
mm/userfaultfd.c | 61 ++---------------
net/ipv4/tcp.c | 31 +++------
rust/kernel/mm.rs | 57 ++++++++++------
tools/testing/vma/include/dup.h | 5 +-
tools/testing/vma/vma_internal.h | 1 -
31 files changed, 166 insertions(+), 395 deletions(-)
base-commit: 1029098ee3275ea5b78e329ce132262affa2f8cc
--
2.55.0.691.gc56d675ccc-goog
next reply other threads:[~2026-08-12 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 1:10 Suren Baghdasaryan [this message]
2026-08-12 1:10 ` [PATCH v5 1/5] mm: Make per-VMA locks available universally Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 2/5] binder: Make shrinker rely solely on per-VMA lock Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 3/5] mm: Add RCU-based VMA lookup helper that waits for writers Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 4/5] binder: Remove mmap_lock fallback Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 5/5] tcp: Remove mmap_lock fallback path Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812011056.902771-1-surenb@google.com \
--to=surenb@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=cmllamas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=tkjos@android.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox