From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9AC0440A34 for ; Wed, 12 Aug 2026 13:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786541299; cv=none; b=MG/GL1VxuT/dOr1eWcnQh1Sklzi9JXmeo4+AcbrnQlHp7tUrxK0um8Z3FWUQ/hnohLZtW5Xy9aBuY1Fzq8ZaFv0PfcTeGAskmoiH25pKUMQ0a5hHk5Al7jbAI2mR5c4aEwvscIt7N3kbFL/aCnU9lFVLAJ1wzVzVEHBsa9jdIyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786541299; c=relaxed/simple; bh=/K//QNBSWbzxPsT5IS9FlHvVWcnHN7kFOdvLuOJD4/0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iXjEzOoyZqQfur3ecc16UPFiW8w+rggX2Nj5hTV+NpFpzlqL4r7vfxhNgO+C8jLt/JRI3bZ86D7+x5RU4nbjOksA8rPq3Adgt48ULVJdfV2092cS5R0/ocXrthtcZQkSPzagHYGBtagf6gLUsOjAnu9SadG41U0GXKmlMHMFWy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ULoV1S9d; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ULoV1S9d" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49558ce01afso7553195e9.1 for ; Wed, 12 Aug 2026 06:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786541294; x=1787146094; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aSDcvewipoZNYTT+WMH6V9nJ9au04QroQYI+jUHvzRg=; b=ULoV1S9dxOYAsDicW0JOdunHFdJorsflR9mPAgOlkcw+XsD8R/aRi/nk8zk2v7DSgo WOq+wWF1ncJxipyU7crgodwdeSsSZqGAUb0SC9qAwPy53qZisNuApz93VU4aIdwgXWkX ncGjJZiV4fEG6+TzVp+1irmyhmPP48eISrtU3fre6r+XxEqqtVuILzJOrhM4cFPeweJC l8jV3olyC3Rg1SiAu4eqin4YfRdnch1Dcvhctm4FjJhCIV50eZS6H1y9DmCEoya2L0Bj 4N4bF7vbObC9E73VVQdk6ksbw2LfHetoMADde6aJm6o2zcG0PyZAlGcdCbEKPCcPZFkk oIgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786541294; x=1787146094; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aSDcvewipoZNYTT+WMH6V9nJ9au04QroQYI+jUHvzRg=; b=SuE6xCAtM3K/R33I/1puPZgy/VmfIsMnRfWZcfwjyhB7ipAOo08ooCJTD/BG6jKiOS 69g0KNW2ICZXyxZWclSzE6qMfhDC/c9eTXaiZiuMuYz+rlAXw6DSo6fhg5pGQTzaS8EW +8jHVeGRIANshXDUxIEzAcRcuYsJTuOA18g4YaYJogVx2srvVeLo+o0rV/w3tGaG2yP6 G1yFkldpfANXoAH+3VzBcZ1oP3EsHPGP7R53N7Mk8HJCUc0cqzO9ZXjRWxiXxzizeX6P SL0VmHJhIqiBSRVPVibOMk+EGkeEcAdE3kHTMQP+VTc2AJIPtMmGSMXgR69Q6FkK1c/z JOYw== X-Forwarded-Encrypted: i=1; AHgh+Rre0tPapeXxv8ICzNY1ozyvJjNPGLWr7gwKieBgkHBeIOsWfBRR7VfYhgG7ayFb+eWQrQ/XKmg=@vger.kernel.org X-Gm-Message-State: AOJu0YzZYghVy5XzqLPdntpeaZF8VZQ6RsFk+/FGtaTq0ULl5/gMEyqe 6/73Gm4dN9nV5AgtJdHaRT+DuTc4VJFYmaYXd2ExDmGOiCbnEvZhKSGz X-Gm-Gg: AR+sD12fFtMNo5js0pfIbrPJS52v3E7WoMkEMKWkjY3vHXQqHb0W+igmWYUPNiQfaBF fgGzWznafwYZxbSGYrk3pYJ+EXKVvKddd9m/+DIQb1zon2KAaoedbySEmQKSj0Uc7GPe7avUgLX P+c2Y22JtW4rRZkkgTaG3/RXOZfJyqm/1v0bi3wgdiOthw0A96fCK6FfIppOHPA92QB2xegubTj FokGAs5KvpE3TI/gzKyZFAPuwLw8X4kjv6lfjfcwndX0/kdPgCHaqwf9AyyZFmsu0MnFpf9wBWv 6Our+u/sFmFv8OYX3jKj1mQ0MGZAigV70KpaZUJqVAmeWc1EOIaNmXHDeFRarE9HsjTm11R5I7p MzvWDC84LTNQEjPrk0409dg90sifvyGtsbD6zG7r0i6ZtyQEtsjYb/9500fpPH+CGPqypPaFcBl 2TbXDniu9XvlDCSJ6YVW5lLhrBB19pBn5/50WHWhEXWh5OiFbeihUAR8Fz9D5faa20KgMdOUW4Q JvZSPOgHTy6rioEWVe9QoEalDuq32zpfKY1eIdC X-Received: by 2002:a05:600c:a207:b0:499:7024:9d4a with SMTP id 5b1f17b1804b1-4997c10e847mr41921955e9.8.1786541293829; Wed, 12 Aug 2026 06:28:13 -0700 (PDT) Received: from localhost.localdomain.pl ([89.151.31.85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997abf917csm87818995e9.13.2026.08.12.06.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 06:28:13 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Florian Fainelli , Jonas Gorski , Vladimir Oltean , netdev@vger.kernel.org, Hauke Mehrtens , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH V3 2/4 net-next?] net: dsa: b53: prefer CPU port 8 for Northstar devices Date: Wed, 12 Aug 2026 15:27:53 +0200 Message-ID: <20260812132755.32585-2-zajec5@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260812132755.32585-1-zajec5@gmail.com> References: <20260812132755.32585-1-zajec5@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Rafał Miłecki It allows using all switch features in opposite to ports 5 and 7. Signed-off-by: Rafał Miłecki --- I think this can be net-next but I was asked to send a complete patchset Can you pick those 2 patches to different trees? drivers/net/dsa/b53/b53_common.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 5fd8362d0430..052812d2faa9 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -766,6 +766,32 @@ void b53_disable_port(struct dsa_switch *ds, int port) } EXPORT_SYMBOL(b53_disable_port); +static struct dsa_port *b53_preferred_default_local_cpu_port(struct dsa_switch *ds) +{ + struct b53_device *dev = ds->priv; + struct dsa_port *cpu_dp; + + /* + * Northstar SoCs devices have 3 Ethernet controllers and 3 CPU ports: + * 5 (IMP1), 7, 8 (IMP0). This design was meant for dual IMP setups when + * WAN traffic goes to port 5 and LAN traffic goes to port 8. + * + * While all 3 ports support Broadcom header, ports 5 and 7 have their + * limitations. Features that relay on trapping to CPU (e.g. EAP, STP) + * won't work when using those as CPU ones. + * + * Prefer CPU port 8 if available. + */ + if (is5301x(dev)) { + cpu_dp = dsa_to_port(ds, B53_CPU_PORT); + + if (dsa_port_is_cpu(cpu_dp)) + return cpu_dp; + } + + return NULL; +} + void b53_brcm_hdr_setup(struct dsa_switch *ds, int port) { struct b53_device *dev = ds->priv; @@ -2724,6 +2750,7 @@ static const struct dsa_switch_ops b53_switch_ops = { .port_setup = b53_setup_port, .port_enable = b53_enable_port, .port_disable = b53_disable_port, + .preferred_default_local_cpu_port = b53_preferred_default_local_cpu_port, .support_eee = b53_support_eee, .set_mac_eee = b53_set_mac_eee, .set_ageing_time = b53_set_ageing_time, -- 2.51.0