Netdev List
 help / color / mirror / Atom feed
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
To: David Heidelberg <david@ixit.cz>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Bjorn Andersson <andersson@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
	Luca Weiss <luca.weiss@fairphone.com>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	oe-linux-nfc@lists.linux.dev,
	Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Subject: Re: [PATCH v5 5/6] nfc: s3fwrn5: support the S3NRN4V variant
Date: Wed, 12 Aug 2026 17:28:25 +0200	[thread overview]
Message-ID: <20260812152825.34300-1-jorijnvdgraaf@catcrafts.net> (raw)
In-Reply-To: <e9b0c679-6a50-48ba-8ce8-684bd4b5606b@ixit.cz>

On Wed, Aug 12, 2026 at 01:18:33PM +0200, David Heidelberg wrote:
> > Assisted-by: Claude:claude-opus-4-8
> > Assisted-by: Claude:claude-fable-5
> > Assisted-by: Claude:claude-opus-5
>
> Here's my mental model:
>
>   - It's good to know that you used an LLM (hence Assisted-by).
>   - Someone may want to reproduce some generated code, so knowing which model was
>     used is useful.
>   - When you put THREE ;-) models there, I think it's getting a bit useless, as
>     we don't know which part was generated or adjusted by which model. At this
>     point, it feels somewhat pointless.

coding-assistants.rst doesn't say what to do when multiple models are
used, and generated-content.rst says to choose transparency when in
doubt, so I kept the tags each patch had accumulated.

Currently I use claude-fable-5 as my coding assistant and
claude-opus-5 only reviews. Earlier I used the opus models for this
as well. Each tag was added when a model wrote code on a patch, then
deliberately carried forward across revisions.

> My recommendation would be to keep just one line for the model used for:
>
> a) the majority of the changes
> b) the last model used (at least for notable changes)
> c) the most powerful model doing the generation and/or review
>
> I personally don't mind either approach. There have been discussions about
> dropping Assisted-by completely, but so far it makes sense to me to keep it,
> just in moderation.

Agreed that three lines are ambiguous. Future patches will carry a
single Assisted-by line for the model actually being used as the
coding assistant, or just "Assisted-by: LLM" if the simplification
now in the docs tree lands [1]. The opus tags can be dropped from this series.

Thanks,
Jorijn

[1] https://lore.kernel.org/all/87qzkuahlr.fsf@trenco.lwn.net/

  reply	other threads:[~2026-08-12 15:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 22:01 [PATCH v5 0/6] nfc: s3fwrn5: support the S3NRN4V variant Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 1/6] nfc: s3fwrn5: drop of_match_ptr() from the I2C driver Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 2/6] nfc: s3fwrn5: use the "s3fwrn5_i2c" string literal directly Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 3/6] dt-bindings: net: nfc: samsung,s3fwrn5: add the S3NRN4V Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 4/6] nfc: s3fwrn5: enable the PVDD supply Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 5/6] nfc: s3fwrn5: support the S3NRN4V variant Jorijn van der Graaf
2026-08-12 11:18   ` David Heidelberg
2026-08-12 15:28     ` Jorijn van der Graaf [this message]
2026-08-11 22:01 ` [PATCH v5 6/6] arm64: dts: qcom: milos-fairphone-fp6: Add NFC Jorijn van der Graaf
2026-08-18 10:27   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260812152825.34300-1-jorijnvdgraaf@catcrafts.net \
    --to=jorijnvdgraaf@catcrafts.net \
    --cc=andersson@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-linux-nfc@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox