From: Abid Ali <dev.taqnialabs@gmail.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <linux@armlinux.org.uk>,
Qingfang Deng <qingfang.deng@linux.dev>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abid Ali <dev.taqnialabs@gmail.com>
Subject: [PATCH v3 0/3] fix the MTL fifo and DMA race condition
Date: Thu, 13 Aug 2026 07:49:26 +0000 [thread overview]
Message-ID: <20260813-stmmac-rx-fifo-block-v3-0-738acbee55d9@gmail.com> (raw)
To: Andrew Lunn <andrew+netdev@lunn.ch>
To: David S. Miller <davem@davemloft.net>
To: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>
To: Russell King <linux@armlinux.org.uk>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Abid Ali <dev.taqnialabs@gmail.com>
Changes in v3:
- v2 tried to fix the ordering in teardown path, but it still would
not follow the ideal flow mentioned in the databook. So have
seperated the patches to deal with the teardown and some findings
from sashiko.
- "net: stmmac: enable MAC rx/tx after DMA start": reduced in scope,
now only moves the MAC enable after stmmac_start_all_dma() in
stmmac_hw_setup() and stmmac_xdp_open().
This is to handle the overflow scenario during bootup causing hang.
The teardown side in __stmmac_release() is no longer touched here.
This change could go independently fix the overflow hang at bootup.
- Added "net: stmmac: xgmac: tear the datapath down in the documented
order": for ensuring ordered sequence is followed for teardown.
- Added "net: stmmac: xgmac: decouple the MAC Rx/Tx enables from the
DMA ops": drops the global TE/RE writes from the per-channel XGMAC
DMA start/stop ops.
- Link to v2: https://lore.kernel.org/r/20260727-stmmac-rx-fifo-block-v2-1-4dc3457d31d0@gmail.com
Changes in v2:
- Corrected the ordering in teardown for xdp at stmmac_xdp_release().
- Link to v1: https://lore.kernel.org/r/20260726-stmmac-rx-fifo-block-v1-1-45ab094b6c02@gmail.com
---
Abid Ali (3):
net: stmmac: enable MAC rx/tx after DMA start
net: stmmac: xgmac: tear the datapath down in the documented order
net: stmmac: xgmac: decouple the MAC Rx/Tx enables from the DMA ops
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 8 ++
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 94 +++++++++++++++++++---
drivers/net/ethernet/stmicro/stmmac/hwif.h | 17 ++++
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 85 ++++++++++++++-----
4 files changed, 170 insertions(+), 34 deletions(-)
---
base-commit: 8cd9520d35a6c38db6567e97dd93b1f11f185dc6
change-id: 20260726-stmmac-rx-fifo-block-ef589c38f96b
Best regards,
--
Abid Ali <dev.taqnialabs@gmail.com>
next reply other threads:[~2026-08-13 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 7:49 Abid Ali [this message]
2026-08-13 7:49 ` [PATCH v3 1/3] net: stmmac: enable MAC rx/tx after DMA start Abid Ali
2026-08-13 7:49 ` [PATCH v3 2/3] net: stmmac: xgmac: tear the datapath down in the documented order Abid Ali
2026-08-13 7:49 ` [PATCH v3 3/3] net: stmmac: xgmac: decouple the MAC Rx/Tx enables from the DMA ops Abid Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813-stmmac-rx-fifo-block-v3-0-738acbee55d9@gmail.com \
--to=dev.taqnialabs@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox