From: Simon Horman <horms@kernel.org>
To: Eric Joyner <eric.joyner@amd.com>
Cc: netdev@vger.kernel.org, Brett Creeley <brett.creeley@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Prabu Thayalan <prabu.ponrajthayalan@amd.com>,
"Nikhil P. Rao" <nikhil.rao@amd.com>
Subject: Re: [PATCH net 0/2] ionic: fix completion descriptor access
Date: Thu, 13 Aug 2026 14:53:50 +0100 [thread overview]
Message-ID: <20260813135350.GD265046@horms.kernel.org> (raw)
In-Reply-To: <20260811195039.1315045-1-eric.joyner@amd.com>
On Tue, Aug 11, 2026 at 12:50:37PM -0700, Eric Joyner wrote:
> The first patch adds the missing dma_rmb() between the completion
> publish checks and the reads of the descriptor payloads, suggested by
> the Sashiko review from [1] for the second patch.
>
> The second locates the completion within its slot from cq->desc_size
> rather than a fixed stride, which is necessary when IONIC_Q_F_2X_CQ_DESC
> (double-sized completion descriptors) is used (e.g. for hardware
> timestamps).
>
> [1] https://lore.kernel.org/netdev/20260507155928.2537928-1-kuba@kernel.org/
>
> Eric Joyner (1):
> ionic: add missing dma_rmb() after the completion publish check
>
> Prabu Thayalan (1):
> ionic: fix completion descriptor access with 2x desc size
For the series:
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-08-13 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 19:50 [PATCH net 0/2] ionic: fix completion descriptor access Eric Joyner
2026-08-11 19:50 ` [PATCH net 1/2] ionic: add missing dma_rmb() after the completion publish check Eric Joyner
2026-08-11 19:50 ` [PATCH net 2/2] ionic: fix completion descriptor access with 2x desc size Eric Joyner
2026-08-13 13:53 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813135350.GD265046@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.rao@amd.com \
--cc=pabeni@redhat.com \
--cc=prabu.ponrajthayalan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox