From: Jakub Kicinski <kuba@kernel.org>
To: Xin Xie <xiexinet@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, shuah@kernel.org, lukma@denx.de,
m-karicheri2@ti.com, fmaurer@redhat.com, luka.gejak@linux.dev,
bigeasy@linutronix.de, ali@iusegentoo.com,
qingfang.deng@linux.dev, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v3 3/3] selftests: net: hsr: add shared-mutation regression test
Date: Thu, 13 Aug 2026 18:30:08 -0700 [thread overview]
Message-ID: <20260813183008.31e14297@kernel.org> (raw)
In-Reply-To: <20260808004525.1551-4-xiexinet@gmail.com>
On Sat, 8 Aug 2026 02:45:24 +0200 Xin Xie wrote:
> + nsx python3 /dev/stdin <<'PYF1'
> +import socket, select, sys, time
It's a "no" on embedded Python in bash scripts.
Where do people get that from? Did AI generate it or are there projects
in which this is common practice?
Please write the whole test in Python (see .../net/lib/py/ helpers),
or move the python code out to its own scrip under TEST_FILES
prev parent reply other threads:[~2026-08-14 1:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 0:45 [PATCH net v3 0/3] net: hsr: fix shared-skb mutations in the forwarding path Xin Xie
2026-08-08 0:45 ` [PATCH net v3 1/3] net: hsr: privatize interlink-bound skbs before address mutation Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-08-14 1:27 ` Jakub Kicinski
2026-08-08 0:45 ` [PATCH net v3 2/3] net: hsr: return private clones from the tagged-frame helpers Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-08-08 0:45 ` [PATCH net v3 3/3] selftests: net: hsr: add shared-mutation regression test Xin Xie
2026-08-10 23:18 ` Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-08-14 1:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813183008.31e14297@kernel.org \
--to=kuba@kernel.org \
--cc=ali@iusegentoo.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=lukma@denx.de \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
--cc=shuah@kernel.org \
--cc=xiexinet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).