From: Gustavo Luiz Duarte <gustavold@gmail.com>
To: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: Gustavo Luiz Duarte <gustavold@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: [PATCH net-next v3 6/7] netconsole: move struct inet_addr into netconsole.c
Date: Fri, 14 Aug 2026 20:28:57 +0100 [thread overview]
Message-ID: <20260814-netcons_ipv6-v3-6-bc0915e8c75f@gmail.com> (raw)
In-Reply-To: <20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com>
The struct inet_addr lives in netpoll.h, but since commit a1116396476f
("netconsole: move local_ip/remote_ip/ipv6 to netconsole_target") the
only user is netconsole. Move the definition into netconsole.c
Suggested-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
---
drivers/net/netconsole.c | 9 +++++++++
include/linux/netpoll.h | 9 ---------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 1f18d0a7d2dd..267254f046de 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -151,6 +151,15 @@ enum target_state {
STATE_DEACTIVATED,
};
+struct inet_addr {
+ /* Address family: AF_UNSPEC when unset, else AF_INET or AF_INET6 */
+ u8 family;
+ union {
+ __be32 ip;
+ struct in6_addr in6;
+ };
+};
+
/**
* struct netcons_userdata - Formatted userdata payload of a target.
* @rcu: Used to free the payload after a grace period.
diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h
index de97f001a0f9..ec0821a5b02d 100644
--- a/include/linux/netpoll.h
+++ b/include/linux/netpoll.h
@@ -16,15 +16,6 @@
#include <linux/ip.h>
#include <linux/udp.h>
-struct inet_addr {
- /* Address family: AF_UNSPEC when unset, else AF_INET or AF_INET6 */
- u8 family;
- union {
- __be32 ip;
- struct in6_addr in6;
- };
-};
-
struct netpoll {
struct net_device *dev;
netdevice_tracker dev_tracker;
--
2.55.0
next prev parent reply other threads:[~2026-08-14 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 19:28 [PATCH net-next v3 0/7] netconsole: validate a target's IP address configuration Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 1/7] netconsole: add an address family to struct inet_addr Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 2/7] netconsole: use the address family instead of the ipv6 flag Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 3/7] netconsole: reject enabling a target with no remote IP address Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 4/7] netconsole: reject a target mixing IPv4 and IPv6 addresses Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 5/7] netconsole: show empty string for an unset IP address Gustavo Luiz Duarte
2026-08-14 19:28 ` Gustavo Luiz Duarte [this message]
2026-08-14 19:28 ` [PATCH net-next v3 7/7] docs: netconsole: document local_ip auto-selection Gustavo Luiz Duarte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814-netcons_ipv6-v3-6-bc0915e8c75f@gmail.com \
--to=gustavold@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox