From: Ido Schimmel <idosch@nvidia.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Michael Blunt <michaelbblunt@gmail.com>
Subject: Re: [PATCH v2 net] inetpeer: randomize RB-tree node comparison using SipHash
Date: Sun, 16 Aug 2026 15:43:59 +0300 [thread overview]
Message-ID: <20260816124359.GA62850@shredder> (raw)
In-Reply-To: <20260814060616.2164504-1-edumazet@google.com>
On Fri, Aug 14, 2026 at 06:06:16AM +0000, Eric Dumazet wrote:
> @@ -190,12 +221,13 @@ struct inet_peer *inet_getpeer(struct inet_peer_base *base,
> write_seqlock_bh(&base->lock);
>
> gc_cnt = 0;
> - p = lookup(daddr, base, seq, gc_stack, &gc_cnt, &parent, &pp);
> + p = lookup(daddr, dhash, base, seq, gc_stack, &gc_cnt, &parent, &pp);
> if (!p) {
> if ((u64)base->total < 2ULL * READ_ONCE(inet_peer_threshold))
> p = kmem_cache_alloc(peer_cachep, GFP_ATOMIC);
Eric, this is a leftover from v1, so the patch doesn't apply :/
> if (p) {
> p->daddr = *daddr;
> + p->hash = dhash;
> p->dtime = (__u32)jiffies;
> refcount_set(&p->refcnt, 1);
> atomic_set(&p->rid, 0);
prev parent reply other threads:[~2026-08-16 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 6:06 [PATCH v2 net] inetpeer: randomize RB-tree node comparison using SipHash Eric Dumazet
2026-08-16 12:43 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260816124359.GA62850@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=michaelbblunt@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox