Netdev List
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Ren Wei <weir@nebusec.ai>,
	ncardwell@google.com, netdev@vger.kernel.org, dsahern@kernel.org,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, vega@nebusec.ai, edragain@163.com
Subject: Re: [PATCH net RESEND 1/1] ipv4: reject RTAX_ADVMSS values below TCP_MIN_MSS
Date: Mon, 17 Aug 2026 13:14:33 +0300	[thread overview]
Message-ID: <20260817101433.GA323029@shredder> (raw)
In-Reply-To: <CANn89iKamqEOMfNmbF9nLGT=+6rPmj3KexW+spPpp4DzJ7G8TA@mail.gmail.com>

On Mon, Aug 17, 2026 at 10:35:32AM +0200, Eric Dumazet wrote:
> Sounds good, although we probably need READ_ONCE()/WRITE_ONCE() annotations.

Thanks for the feedback, Eric.

Is this something you want to post separately from the diff I suggested?

They don't conflict and my diff merely adds a floor to the return value
of dst_metric_advmss(), which TCP already calls.

If you are OK with posting yours separately, then the author can prepare
v2 based on the diff I pasted.

Thanks

  reply	other threads:[~2026-08-17 10:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 17:05 [PATCH net RESEND 0/1] ipv4: fix divide-by-zero from undersized RTAX_ADVMSS Ren Wei
2026-08-13 17:05 ` [PATCH net RESEND 1/1] ipv4: reject RTAX_ADVMSS values below TCP_MIN_MSS Ren Wei
2026-08-17  8:28   ` Ido Schimmel
2026-08-17  8:35     ` Eric Dumazet
2026-08-17 10:14       ` Ido Schimmel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-28  5:08 [PATCH net 0/1] ipv4: fix divide-by-zero from undersized RTAX_ADVMSS Ren Wei
2026-07-28  5:08 ` [PATCH net 1/1] ipv4: reject RTAX_ADVMSS values below TCP_MIN_MSS Ren Wei
2026-08-06  4:13   ` [PATCH net RESEND " Ren Wei
2026-08-06 14:15   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817101433.GA323029@shredder \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edragain@163.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vega@nebusec.ai \
    --cc=weir@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox