From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Liu <1298662399@qq.com>
Cc: Jian Shen <shenjian15@huawei.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering
Date: Tue, 18 Aug 2026 08:06:13 -0700 [thread overview]
Message-ID: <20260818080613.045d764b@kernel.org> (raw)
In-Reply-To: <tencent_1B2B4E438079BF5595B1F50C45FF9067BA08@qq.com>
On Tue, 18 Aug 2026 17:13:29 +0400 Jiawen Liu wrote:
> Remove the redundant explicit NAPI deletion from the registered-device
> remove path.
>
> The confirmed lifecycle contract is that unregister_netdev() performs
> the NAPI teardown. Probe failure cleanup before registration remains
> unchanged.
We discourage pointless code churn like this.
If you think there's a bug explain it better.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: reject
prev parent reply other threads:[~2026-08-18 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 13:13 [PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering Jiawen Liu
2026-08-18 15:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818080613.045d764b@kernel.org \
--to=kuba@kernel.org \
--cc=1298662399@qq.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox