From: Hillf Danton <hdanton@sina.com>
To: Junjie Cao <junjie.cao@intel.com>
Cc: Eric Dumazet <edumazet@google.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Uladzislau Zhauniarovich <uladzislau.zhauniarovich@gmail.com>,
syzbot+19d01f6082ec61dd45b2@syzkaller.appspotmail.com,
syzbot+8785aaf121cfb2141e0d@syzkaller.appspotmail.com,
syzbot+2642f347f7309b4880dc@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 1/3] net/sched: taprio: catch up in bounded time when the schedule falls behind
Date: Wed, 19 Aug 2026 15:50:14 +0800 [thread overview]
Message-ID: <20260819075015.1259-1-hdanton@sina.com> (raw)
In-Reply-To: <20260818071706.251035-2-junjie.cao@intel.com>
On Tue, 18 Aug 2026 15:17:04 +0800 Junjie Cao wrote:
> @@ -960,14 +1005,19 @@ static enum hrtimer_restart advance_sched(struct hrtimer *timer)
> next = list_next_entry(entry, list);
> }
>
> - end_time = ktime_add_ns(entry->end_time, next->interval);
> + next_start = entry->end_time;
> + end_time = ktime_add_ns(next_start, next->interval);
> end_time = min_t(ktime_t, end_time, oper->cycle_end_time);
>
> + now = taprio_get_time(q);
> + if (unlikely(ktime_before(end_time, now)))
> + taprio_catch_up(oper, &next, &next_start, &end_time, now);
> +
If now is computed based on the timer instead, now = timer->base->get_time(),
which one do you pick up lad/dude?
next prev parent reply other threads:[~2026-08-19 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 7:17 [PATCH net 0/3] net/sched: taprio: fix software schedule livelocks Junjie Cao
2026-08-18 7:17 ` [PATCH net 1/3] net/sched: taprio: catch up in bounded time when the schedule falls behind Junjie Cao
2026-08-19 7:50 ` Hillf Danton [this message]
2026-08-18 7:17 ` [PATCH net 2/3] net/sched: taprio: enforce a minimum interval for software schedules Junjie Cao
2026-08-18 7:17 ` [PATCH net 3/3] selftests/tc-testing: taprio: add case for the software minimum interval Junjie Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819075015.1259-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=edumazet@google.com \
--cc=junjie.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+19d01f6082ec61dd45b2@syzkaller.appspotmail.com \
--cc=syzbot+2642f347f7309b4880dc@syzkaller.appspotmail.com \
--cc=syzbot+8785aaf121cfb2141e0d@syzkaller.appspotmail.com \
--cc=uladzislau.zhauniarovich@gmail.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox