From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D97D47F779; Thu, 20 Aug 2026 17:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787246701; cv=none; b=mdmp83zoK0vhuzPnh5xJ+lDmNxmKw7HyfOC8+UiR+bh/vtDREk0xnerBTFPyDjL9z0ntUUYEUaqcDwM0+/F0S49M27Uam+hQTmE1yDSREzC950oQGT+rOF05iF3AmNiVbWiYpGncw6SZOPjYTixLurWMba48YQhEyU3iJ6TPuwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787246701; c=relaxed/simple; bh=TYoZJnylonKUl64989RBp4942of/+/SC1658Xdgn7Tk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kYglHt0fXiFYY7w9y0jO16Mw2l/jPE5i93cYluwvTEu/XT49aC2Ib6cXlXpH1yjLMUBEIx2y68IjYyiRseJ4nmZClrODfAAUyImYP4/Vh99wmkeK34HeZPArR26y+L9jQ32sslfjePRFVEeFnT88q/+U4MBnf0tXT12+aQgm0LA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KqfKnoc/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KqfKnoc/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 925801F000E9; Thu, 20 Aug 2026 17:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787246700; bh=4R26jjf5EAdEgjitYVP1gkrdr/QO/CbWlMwBRvsHNzY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KqfKnoc/4JD+ts6rcoWaGua/u2Ecod6+E/lNf+5dRB24C2XAPmofNzTqglhPdYTOw P5BNjVl1d+LmUO9S3VjN9gajR9Ei11OkDRuvlpi9Yu2fhiWblTtZUnLKkMuoHrbNqx kq9ClkIraQ9bF4Sb5p0bxN7WLC6AsaOu7Xu/bYrsGfNAXafTr4Y2ru5a4kKHcLPOiv 8Q0MAVQNnumI4rkRd43TGuyT62e05W64dmov0N3S3rS9eyTJg9xJDuc5HnpjzZmhFq p1x93yr4wgAoD64muEd2Q0kXaLeEbyh+X/KAy3cui1dTXTTyIHabv81O8pRZlA6KXd gYjzW9EHoj1Dg== Date: Thu, 20 Aug 2026 10:24:58 -0700 From: Jakub Kicinski To: Sebastian Andrzej Siewior Cc: Daniel Machon , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Steen Hegelund , UNGLinuxDriver@microchip.com, Clark Williams , Steven Rostedt , Bjarni Jonasson , Lars Povlsen , Philipp Zabel , kees@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rt-devel@lists.linux.dev Subject: Re: [PATCH net v3 2/2] net: sparx5: fix sleep in atomic context in MAC table access Message-ID: <20260820102458.308b78ba@kernel.org> In-Reply-To: <20260820143443.RTYj4Q3u@linutronix.de> References: <20260817-misc-fixes-sparx5-lan969x-v3-0-c7c7fef723a8@microchip.com> <20260817-misc-fixes-sparx5-lan969x-v3-2-c7c7fef723a8@microchip.com> <20260820143443.RTYj4Q3u@linutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 20 Aug 2026 16:34:43 +0200 Sebastian Andrzej Siewior wrote: > On 2026-08-17 17:41:59 [+0200], Daniel Machon wrote: > =E2=80=A6 > > Fixes: d6fce5141929 ("net: sparx5: add switching support") > > Signed-off-by: Daniel Machon =20 > =E2=80=A6 > > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c b/dr= ivers/net/ethernet/microchip/sparx5/sparx5_netdev.c > > index 1d34af78166a..4dedf5d92641 100644 > > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c > > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c > > @@ -249,7 +254,7 @@ static const struct net_device_ops sparx5_port_netd= ev_ops =3D { > > .ndo_open =3D sparx5_port_open, > > .ndo_stop =3D sparx5_port_stop, > > .ndo_start_xmit =3D sparx5_port_xmit_impl, > > - .ndo_set_rx_mode =3D sparx5_set_rx_mode, > > + .ndo_set_rx_mode_async =3D sparx5_set_rx_mode, > > .ndo_get_phys_port_name =3D sparx5_port_get_phys_port_name, > > .ndo_set_mac_address =3D sparx5_set_mac_address, > > .ndo_validate_addr =3D eth_validate_addr, =20 >=20 > d6fce5141929 is v5.14-rc1 > ndo_set_rx_mode_async has been introduced in v7.1-rc1. > Youngest LTS kernel is v6.18. >=20 > What would be the "fix" for the kernels v5.15 =E2=80=A6 v6.18? stable should backport .ndo_set_rx_mode_async there's been a number of similar fixes, and the whole point of=20 the new ndo was to help drivers avoid the sleeping in atomic bugs