From: Simon Horman <horms@kernel.org>
To: Subrat Pandey <subratp@marvell.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch, sbhatta@marvell.com,
rkannoth@marvell.com, gakula@marvell.com, sgoutham@marvell.com
Subject: Re: [PATCH net v4 1/2] octeontx2-pf: Fix aura BPID assignment when CONFIG_DCB is enabled
Date: Thu, 20 Aug 2026 19:23:17 +0100 [thread overview]
Message-ID: <20260820182317.GB265046@horms.kernel.org> (raw)
In-Reply-To: <20260818091124.1832237-2-subratp@marvell.com>
On Tue, Aug 18, 2026 at 02:41:22PM +0530, Subrat Pandey wrote:
...
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> index eecee612b7b2..f39b293cc837 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> @@ -1029,6 +1029,14 @@ static inline int otx2_tc_flower_rule_cnt(struct otx2_nic *pfvf)
> return pfvf->flow_cfg->nr_flows;
> }
>
> +static inline u8 otx2_get_bpid_idx(struct otx2_nic *pfvf, int qidx)
> +{
> + if (IS_ENABLED(CONFIG_DCB))
> + return pfvf->queue_to_pfc_map[qidx];
> +
> + return 0;
> +}
> +
Hi,
As pointed out by sashiko.dev [1], this will not compile if
CONFIG_DCB is not defined because the compiler will
evaluate pfvf->queue_to_pfc_map, and that field doesn't exist
without CONFIG_DCB set.
[1] https://sashiko.dev/#/patchset/20260818091124.1832237-1-subratp%40marvell.com
--
pw-bot: changes-requested
next prev parent reply other threads:[~2026-08-20 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 9:11 [PATCH net v4 0/2] octeontx2: Misc fixes for RVU drivers Subrat Pandey
2026-08-18 9:11 ` [PATCH net v4 1/2] octeontx2-pf: Fix aura BPID assignment when CONFIG_DCB is enabled Subrat Pandey
2026-08-20 18:23 ` Simon Horman [this message]
2026-08-18 9:11 ` [PATCH net v4 2/2] octeontx2-af: mcs: Fix SC resource cleanup loop Subrat Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820182317.GB265046@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=subratp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox