From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: victor@mojatatu.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jiri@resnulli.us, horms@kernel.org,
bestswngs@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: sch_teql: restore skb->dev on the slave failure path
Date: Fri, 21 Aug 2026 16:30:20 -0700 [thread overview]
Message-ID: <20260821163020.41d2d5bb@kernel.org> (raw)
In-Reply-To: <CAM0EoMmXhqmuSkLCS1hXczFK4GZtQR2Gy1YZ5Vx2wfqCD87PDA@mail.gmail.com>
On Fri, 21 Aug 2026 12:04:12 -0400 Jamal Hadi Salim wrote:
> > This is an AI-generated review of your patch. The human sending this
> > email has considered the AI review valid, or at least plausible.
> > ---
> > net/sched: sch_teql: restore skb->dev on the slave failure path
> >
> > teql_master_xmit() used to leave skb->dev pointing at a slave after that
> > slave's ndo_start_xmit() failed, so the skb could end up queued on a later
> > slave's neighbour arp_queue while referring to the earlier slave. The
> > patch restores skb->dev to the master device at the end of each slave
> > iteration.
> >
>
> Let's please apply this patch. The patch correctly fixes the reported
> UAF (namespace-reachable, slave deleted while skb queued on another
> slave's neighbour).
It's way too old now, just repost if you think it's good as is.
prev parent reply other threads:[~2026-08-21 23:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 13:31 [PATCH net] net/sched: sch_teql: restore skb->dev on the slave failure path Victor Nogueira
2026-08-11 0:11 ` Jakub Kicinski
2026-08-21 16:04 ` Jamal Hadi Salim
2026-08-21 23:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821163020.41d2d5bb@kernel.org \
--to=kuba@kernel.org \
--cc=bestswngs@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox