From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F7C38238F for ; Fri, 21 Aug 2026 18:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787336720; cv=none; b=kG6wbv1VNbbjtwQgxgEnYrzDW+XQhH69Xeq9kt9a/7qPmyTAjvh1GciUGH5pZBOMMU+PF83dUIXQ+WLLWXWTpTBDiA3gMQ+So/L74OrR6bKr7zS7s5k0sRPexcdwoNMpswg9BkzkRtvE1f3MkthW0ttaUMNJqbCNIJk3En0jotM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787336720; c=relaxed/simple; bh=XmKuM/0b01xWi9YKVoLDLMW2oWBahlMckE8zXLiEyq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mdyhs4RbiTq7WEgUhA1slGm5dVyefVYnaAj6tpUaGPcCFVeKE1QXMdOJ5/OH+5wAqN4DNNHz8pFRyUbYTspbBjD/p+yGMow3073YymffYtINPlNpP/LlsJVAyVsWpqs8JGYtv9kS/In+nNcovU/5zOZCF1SkzRybq5oxwllMG5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gh9kn9QX; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gh9kn9QX" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-cbedda4c154so793867a12.1 for ; Fri, 21 Aug 2026 11:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787336718; x=1787941518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BODlkzVUXjqQa90yL80vDBlFyCIYJnEhwn1aK5Y4XIs=; b=gh9kn9QXRC6VCpjAdXQ6hneIEFkMosprNIM7FHktLX+reWgR6XF9tL/mhK5kOh0muI LY8ClTHwffYcJrdh+f6H1sxXVr0v94AXql/+P4Y4d4y9xsbRYrru3JmG4wHzb/KMpRk5 /vUZbFcikVGIXvzXnziLaKG4TMjGzc4gNwKf/raZACPWr5IfAakC7lyk83oCCE9hIZUj x14L7Js2g/uEF9jzXysJHTt/hz7R5qtmdwEa4uYI+KARnbNdB4QuU98EfKAeXxzQCEJK 8YVqbgkr9YmwL2XSIq6eESRsXyNEizh7aLX4l40LO+bpJEwTN7l2qqJsVmWqqXAoBF7H pBEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787336718; x=1787941518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BODlkzVUXjqQa90yL80vDBlFyCIYJnEhwn1aK5Y4XIs=; b=B5pI7gCWy1ahnW8Yi5Xd8MqUaanhzdmimvQKK0HlFrDd4qLeIFHaMKmB2moFkOvngn Kf6U5n6SwT7pl9d961IE1Hv1DeMwdAfHZ7L5/8tVViwvIKbBczfAf8joSFtr2GOIwIvO KcWXXgvK7/I6LTwdaPgjFXN6qqGEAdvHYOEpLaMmBm56fv5S+R/g7ygjLRInZVp80FKp KfHbABNngFROHkrMB5bn1ogMP6ZSSdzKpHM/mYsNodZMI4UZ2M2eA03pM1lkj7iSISQ8 l+b1T/pKLVJJg1ooTb1fkRvrSJnANocn8O9OW5H2AagPY682g32z+XiDy1Ie1yJ44eC7 txjQ== X-Forwarded-Encrypted: i=1; AHgh+RqF6kapgtauOfnkhOoYHSo5YK8teZsxcDvFLrn3x2f3wn+KBXGqYpMKNqPXox/PcWEooP32PMk=@vger.kernel.org X-Gm-Message-State: AFuF++mlGH4U4K1hk7sTE+Z8ogM1McY9eOdZTlYyIIfB44QImfMazQt5 RKXGV+q8unRwjeT29ZxZLFeJmTSRfmmO5ZT50rrET8WIezRo7+ElALnK X-Gm-Gg: AR+sD132RJ/mCmnVqMe4hD0T5RShdZLZ+Sr3wQnVjspF19NoJXXHPvrnoHDNuQVb7OI +CbA4kxibYa56GbLJXtP+lwGEY9i6DLA3EvcWitQ6kuJl9LfqIds6ivh/DsDO6uB95005mS7cdf CyzOd9y5d+sKjv7pkPSzlK/dKYxmuGgZ4ztHfj0xRwg3c5B8kemXAS4BbRF/aX1UGez2uRd5ny6 doEUXTSp3EmpgTZ+i5Qz0dU4cxxqMzUATHCCs4qCnLq+MEIr/j8azKoUQhw9z+SXgirz1pHU7Gm HqNfZ4+snLl9vLkvLuTYvuPEA41hk66Q0yC8rPtivd24XA9wcI+iNMWUkue/sdjIM8MjWhXPCWu hEcEi8kysNGABY+fcTESdX5Pqnji/QSHagHvtnPThrqRhjiHTebfWT1qhMNbpz1vS0wpIWY8T9o myGTpCz6wT5MZAwnxigY/1OTbfwtmE2pHCmpt8EgKhjxY9M+/yw++2FRbJngtm+2aMhZUjXMt2t yn85ANUoUX/lkpBJzjj9pUp99H+EEJP/zvJ X-Received: by 2002:a17:90b:3149:b0:38e:ad9d:1151 with SMTP id 98e67ed59e1d1-395c33ec565mr14588270a91.4.1787336718383; Fri, 21 Aug 2026 11:25:18 -0700 (PDT) Received: from localhost.localdomain ([2001:4898:a800:1012:54e3:69b5:423e:871a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c45539a1sm4243013a91.3.2026.08.21.11.25.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Aug 2026 11:25:17 -0700 (PDT) From: "Cen Zhang (Microsoft)" To: edumazet@google.com, ncardwell@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: kuniyu@google.com, horms@kernel.org, yhs@fb.com, kafai@fb.com, andriin@fb.com, ast@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, xmei5@asu.edu, tgopinath@linux.microsoft.com, kys@microsoft.com, blbllhy@gmail.com, stable@vger.kernel.org Subject: [PATCH net 1/2] tcp: fix use-after-free in do_tcp_getsockopt(TCP_CONGESTION) Date: Fri, 21 Aug 2026 14:24:48 -0400 Message-ID: <20260821182449.79785-2-blbllhy@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821182449.79785-1-blbllhy@gmail.com> References: <20260821182449.79785-1-blbllhy@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit do_tcp_getsockopt() reads icsk->icsk_ca_ops->name without holding rcu_read_lock(). Since commit 0baf26b0fcd7 ("bpf: tcp: Support tcp_congestion_ops in bpf"), icsk_ca_ops can point to dynamically allocated BPF struct_ops memory that may be freed concurrently via setsockopt(TCP_CONGESTION), leading to a use-after-free. BUG: KASAN: slab-use-after-free in _copy_to_user+0x37/0x60 Read of size 16 at addr ffff888013505260 by task exploit/149 _copy_to_user+0x37/0x60 do_tcp_getsockopt+0x158a/0x2460 (net/ipv4/tcp.c:4585) tcp_getsockopt+0x91/0xf0 __sys_getsockopt+0xf7/0x170 Fix this by holding rcu_read_lock() around the ca_ops->name access and copying the name to a stack buffer before releasing the lock. Fixes: 0baf26b0fcd7 ("bpf: tcp: Support tcp_congestion_ops in bpf") Reported-by: AutonomousCodeSecurity@microsoft.com Reported-by: Xiang Mei (Microsoft) Reported-by: Cen Zhang (Microsoft) Cc: stable@vger.kernel.org Signed-off-by: Cen Zhang (Microsoft) --- The unsynchronized icsk_ca_ops load also constitutes a data race. READ_ONCE()/WRITE_ONCE() annotations are intentionally left to a separate change; related TCP annotation work is available at: https://lore.kernel.org/all/20260416200319.3608680-1-edumazet@google.com/ net/ipv4/tcp.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index b4237d0e994d..7360ff718f1d 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -4577,16 +4577,23 @@ int do_tcp_getsockopt(struct sock *sk, int level, val = !inet_csk_in_pingpong_mode(sk); break; - case TCP_CONGESTION: + case TCP_CONGESTION: { + char ca_name[TCP_CA_NAME_MAX] = {}; + if (copy_from_sockptr(&len, optlen, sizeof(int))) return -EFAULT; len = min_t(unsigned int, len, TCP_CA_NAME_MAX); if (copy_to_sockptr(optlen, &len, sizeof(int))) return -EFAULT; - if (copy_to_sockptr(optval, icsk->icsk_ca_ops->name, len)) + + rcu_read_lock(); + memcpy(ca_name, icsk->icsk_ca_ops->name, sizeof(ca_name)); + rcu_read_unlock(); + + if (copy_to_sockptr(optval, ca_name, len)) return -EFAULT; return 0; - + } case TCP_ULP: if (copy_from_sockptr(&len, optlen, sizeof(int))) return -EFAULT; -- 2.55.0